Add cargoflags to toolchain configuration #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ I don't think we need to bother with shlex or similar -- if that becomes an issue, I'd rather change the encoding such that we can specify flags via the DB or something and just manually adjust when necessary or so. |
|
📌 Commit 250680b has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to test the new scrape examples feature using Crater. Because it's gated behind a Cargo flag
-Zrustdoc-scrape-examples, I added the ability for Crater to take as input a new+cargoflags=...configuration for toolchains, similar to how+rustflagsworks.One possible implementation issue: I'm doing
cargoflags.split(' ')to split up the provided flags so as to pass them into the command builder. A more robust method would be to use a crate like shlex. I'm not sure if this is important enough to add the dependency, or if there's a better way to do this.