-
Notifications
You must be signed in to change notification settings - Fork 597
/
user.rs
571 lines (488 loc) · 18.5 KB
/
user.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
use crate::{
builders::{CrateBuilder, VersionBuilder},
new_user,
util::{MockCookieUser, RequestHelper, Response},
OkBool, TestApp,
};
use cargo_registry::{
models::{Email, NewUser, User},
views::{EncodablePrivateUser, EncodablePublicUser, EncodableVersion},
};
use diesel::prelude::*;
#[derive(Deserialize)]
struct AuthResponse {
url: String,
state: String,
}
#[derive(Deserialize)]
pub struct UserShowPublicResponse {
pub user: EncodablePublicUser,
}
#[derive(Deserialize)]
pub struct UserShowPrivateResponse {
pub user: EncodablePrivateUser,
}
#[derive(Deserialize)]
struct UserStats {
total_downloads: i64,
}
impl crate::util::MockCookieUser {
fn show_me(&self) -> UserShowPrivateResponse {
let url = "/api/v1/me";
self.get(url).good()
}
fn update_email(&self, email: &str) -> OkBool {
let model = self.as_model();
self.update_email_more_control(model.id, Some(email)).good()
}
// TODO: I don't like the name of this method or the one above; this is starting to look like
// a builder might help? I want to explore alternative abstractions in any case
fn update_email_more_control(&self, user_id: i32, email: Option<&str>) -> Response<OkBool> {
// When updating your email in crates.io, the request goes to the user route with PUT.
// Ember sends all the user attributes. We check to make sure the ID in the URL matches
// the ID of the currently logged in user, then we ignore everything but the email address.
let body = json!({"user": {
"email": email,
"name": "Arbitrary Name",
"login": "arbitrary_login",
"avatar": "https://arbitrary.com/img.jpg",
"url": "https://arbitrary.com",
"kind": null
}});
let url = format!("/api/v1/users/{}", user_id);
self.put(&url, body.to_string().as_bytes())
}
fn confirm_email(&self, email_token: &str) -> OkBool {
let url = format!("/api/v1/confirm/{}", email_token);
self.put(&url, &[]).good()
}
}
impl crate::util::MockAnonymousUser {
// TODO: Refactor to get rid of this duplication with the same method implemented on
// MockCookieUser
fn update_email_more_control(&self, user_id: i32, email: Option<&str>) -> Response<OkBool> {
// When updating your email in crates.io, the request goes to the user route with PUT.
// Ember sends all the user attributes. We check to make sure the ID in the URL matches
// the ID of the currently logged in user, then we ignore everything but the email address.
let body = json!({"user": {
"email": email,
"name": "Arbitrary Name",
"login": "arbitrary_login",
"avatar": "https://arbitrary.com/img.jpg",
"url": "https://arbitrary.com",
"kind": null
}});
let url = format!("/api/v1/users/{}", user_id);
self.put(&url, body.to_string().as_bytes())
}
}
#[test]
fn auth_gives_a_token() {
let (_, anon) = TestApp::init().empty();
let json: AuthResponse = anon.get("/authorize_url").good();
assert!(json.url.contains(&json.state));
}
#[test]
fn access_token_needs_data() {
let (_, anon) = TestApp::init().empty();
let json = anon.get::<()>("/authorize").bad_with_status(200); // Change endpoint to 400?
assert!(json.errors[0].detail.contains("invalid state"));
}
#[test]
fn me() {
let url = "/api/v1/me";
let (app, anon) = TestApp::init().empty();
anon.get(url).assert_forbidden();
let user = app.db_new_user("foo");
let json = user.show_me();
assert_eq!(json.user.email, user.as_model().email);
}
#[test]
fn show() {
let (app, anon, _) = TestApp::init().with_user();
app.db_new_user("bar");
let json: UserShowPublicResponse = anon.get("/api/v1/users/foo").good();
assert_eq!("foo", json.user.login);
let json: UserShowPublicResponse = anon.get("/api/v1/users/bar").good();
assert_eq!("bar", json.user.login);
assert_eq!(Some("https://github.com/bar".into()), json.user.url);
}
#[test]
fn show_latest_user_case_insensitively() {
let (app, anon) = TestApp::init().empty();
app.db(|conn| {
// Please do not delete or modify the setup of this test in order to get it to pass.
// This setup mimics how GitHub works. If someone abandons a GitHub account, the username is
// available for anyone to take. We need to support having multiple user accounts
// with the same gh_login in crates.io. `gh_id` is stable across renames, so that field
// should be used for uniquely identifying GitHub accounts whenever possible. For the
// crates.io/user/:username pages, the best we can do is show the last crates.io account
// created with that username.
t!(NewUser::new(
1,
"foobar",
Some("foo@bar.com"),
Some("I was first then deleted my github account"),
None,
"bar"
)
.create_or_update(conn));
t!(NewUser::new(
2,
"FOOBAR",
Some("later-foo@bar.com"),
Some("I was second, I took the foobar username on github"),
None,
"bar"
)
.create_or_update(conn));
});
let json: UserShowPublicResponse = anon.get("api/v1/users/fOObAr").good();
assert_eq!(
"I was second, I took the foobar username on github",
json.user.name.unwrap()
);
}
#[test]
fn crates_by_user_id() {
let (app, _, user) = TestApp::init().with_user();
let id = user.as_model().id;
app.db(|conn| {
CrateBuilder::new("foo_my_packages", id).expect_build(conn);
});
let response = user.search_by_user_id(id);
assert_eq!(response.crates.len(), 1);
}
#[test]
fn crates_by_user_id_not_including_deleted_owners() {
let (app, anon, user) = TestApp::init().with_user();
let user = user.as_model();
app.db(|conn| {
let krate = CrateBuilder::new("foo_my_packages", user.id).expect_build(conn);
krate
.owner_remove(app.as_inner(), conn, user, "foo")
.unwrap();
});
let response = anon.search_by_user_id(user.id);
assert_eq!(response.crates.len(), 0);
}
#[test]
fn following() {
use cargo_registry::schema::versions;
use diesel::update;
#[derive(Deserialize)]
struct R {
versions: Vec<EncodableVersion>,
meta: Meta,
}
#[derive(Deserialize)]
struct Meta {
more: bool,
}
let (app, _, user) = TestApp::init().with_user();
let user_model = user.as_model();
let user_id = user_model.id;
app.db(|conn| {
CrateBuilder::new("foo_fighters", user_id)
.version(VersionBuilder::new("1.0.0"))
.expect_build(conn);
// Make foo_fighters's version mimic a version published before we started recording who
// published versions
let none: Option<i32> = None;
update(versions::table)
.set(versions::published_by.eq(none))
.execute(conn)
.unwrap();
CrateBuilder::new("bar_fighters", user_id)
.version(VersionBuilder::new("1.0.0"))
.expect_build(conn);
});
let r: R = user.get("/api/v1/me/updates").good();
assert_eq!(r.versions.len(), 0);
assert_eq!(r.meta.more, false);
user.put::<OkBool>("/api/v1/crates/foo_fighters/follow", b"")
.good();
user.put::<OkBool>("/api/v1/crates/bar_fighters/follow", b"")
.good();
let r: R = user.get("/api/v1/me/updates").good();
assert_eq!(r.versions.len(), 2);
assert_eq!(r.meta.more, false);
let foo_version = r
.versions
.iter()
.find(|v| v.krate == "foo_fighters")
.unwrap();
assert!(foo_version.published_by.is_none());
let bar_version = r
.versions
.iter()
.find(|v| v.krate == "bar_fighters")
.unwrap();
assert_eq!(
bar_version.published_by.as_ref().unwrap().login,
user_model.gh_login
);
let r: R = user
.get_with_query("/api/v1/me/updates", "per_page=1")
.good();
assert_eq!(r.versions.len(), 1);
assert_eq!(r.meta.more, true);
user.delete::<OkBool>("/api/v1/crates/bar_fighters/follow")
.good();
let r: R = user
.get_with_query("/api/v1/me/updates", "page=2&per_page=1")
.good();
assert_eq!(r.versions.len(), 0);
assert_eq!(r.meta.more, false);
user.get_with_query::<()>("/api/v1/me/updates", "page=0")
.bad_with_status(200); // TODO: Should be 500
}
#[test]
fn user_total_downloads() {
use diesel::update;
let (app, anon, user) = TestApp::init().with_user();
let user = user.as_model();
let another_user = app.db_new_user("bar");
let another_user = another_user.as_model();
app.db(|conn| {
let mut krate = CrateBuilder::new("foo_krate1", user.id).expect_build(conn);
krate.downloads = 10;
update(&krate).set(&krate).execute(conn).unwrap();
let mut krate2 = CrateBuilder::new("foo_krate2", user.id).expect_build(conn);
krate2.downloads = 20;
update(&krate2).set(&krate2).execute(conn).unwrap();
let mut another_krate = CrateBuilder::new("bar_krate1", another_user.id).expect_build(conn);
another_krate.downloads = 2;
update(&another_krate)
.set(&another_krate)
.execute(conn)
.unwrap();
});
let url = format!("/api/v1/users/{}/stats", user.id);
let stats: UserStats = anon.get(&url).good();
assert_eq!(stats.total_downloads, 30); // instead of 32
}
#[test]
fn user_total_downloads_no_crates() {
let (_, anon, user) = TestApp::init().with_user();
let user = user.as_model();
let url = format!("/api/v1/users/{}/stats", user.id);
let stats: UserStats = anon.get(&url).good();
assert_eq!(stats.total_downloads, 0);
}
#[test]
fn updating_existing_user_doesnt_change_api_token() {
let (app, _, user, token) = TestApp::init().with_token();
let gh_id = user.as_model().gh_id;
let token = &token.as_model().token;
let user = app.db(|conn| {
// Reuse gh_id but use new gh_login and gh_access_token
t!(NewUser::new(gh_id, "bar", None, None, None, "bar_token").create_or_update(conn));
// Use the original API token to find the now updated user
t!(User::find_by_api_token(conn, token))
});
assert_eq!("bar", user.gh_login);
assert_eq!("bar_token", user.gh_access_token);
}
/* Given a GitHub user, check that if the user logs in,
updates their email, logs out, then logs back in, the
email they added to crates.io will not be overwritten
by the information sent by GitHub.
This bug is problematic if the user's email preferences
are set to private on GitHub, as GitHub will always
send none as the email and we will end up inadvertenly
deleting their email when they sign back in.
*/
#[test]
fn github_without_email_does_not_overwrite_email() {
let (app, _) = TestApp::init().empty();
// Simulate logging in via GitHub with an account that has no email.
// Because faking GitHub is terrible, call what GithubUser::save_to_database does directly.
// Don't use app.db_new_user because it adds a verified email.
let user_without_github_email = app.db(|conn| {
let u = new_user("arbitrary_username");
let u = u.create_or_update(conn).unwrap();
MockCookieUser::new(&app, u)
});
let user_without_github_email_model = user_without_github_email.as_model();
let json = user_without_github_email.show_me();
// Check that the setup is correct and the user indeed has no email
assert_eq!(json.user.email, None);
// Add an email address in crates.io
user_without_github_email.update_email("apricot@apricots.apricot");
// Simulate the same user logging in via GitHub again, still with no email in GitHub.
let again_user_without_github_email = app.db(|conn| {
let u = NewUser {
// Use the same github ID to link to the existing account
gh_id: user_without_github_email_model.gh_id,
// new_user uses a None email; the rest of the fields are arbitrary
..new_user("arbitrary_username")
};
let u = u.create_or_update(conn).unwrap();
MockCookieUser::new(&app, u)
});
let json = again_user_without_github_email.show_me();
assert_eq!(json.user.email.unwrap(), "apricot@apricots.apricot");
}
/* Given a new user, test that if they sign in with one email, change their email on GitHub, then
sign in again, that the email in crates.io will remain set to the original email used on GitHub.
*/
#[test]
fn github_with_email_does_not_overwrite_email() {
let (app, _, user) = TestApp::init().with_user();
let model = user.as_model();
let original_email = &model.email;
let new_github_email = "new-email-in-github@example.com";
// Simulate logging in to crates.io after changing your email in GitHub
let user_with_different_email_in_github = app.db(|conn| {
let u = NewUser {
// Use the same github ID to link to the existing account
gh_id: model.gh_id,
email: Some(new_github_email),
// the rest of the fields are arbitrary
..new_user("arbitrary_username")
};
let u = u.create_or_update(conn).unwrap();
MockCookieUser::new(&app, u)
});
let json = user_with_different_email_in_github.show_me();
assert_eq!(json.user.email, *original_email);
}
/* Given a crates.io user, check that the user's email can be
updated in the database (PUT /user/:user_id), then check
that the updated email is sent back to the user (GET /me).
*/
#[test]
fn test_email_get_and_put() {
let (_app, _anon, user) = TestApp::init().with_user();
let json = user.show_me();
assert_eq!(json.user.email.unwrap(), "something@example.com");
user.update_email("mango@mangos.mango");
let json = user.show_me();
assert_eq!(json.user.email.unwrap(), "mango@mangos.mango");
assert!(!json.user.email_verified);
assert!(json.user.email_verification_sent);
}
/* Given a crates.io user, check to make sure that the user
cannot add to the database an empty string or null as
their email. If an attempt is made, update_user.rs will
return an error indicating that an empty email cannot be
added.
This is checked on the frontend already, but I'd like to
make sure that a user cannot get around that and delete
their email by adding an empty string.
*/
#[test]
fn test_empty_email_not_added() {
let (_app, _anon, user) = TestApp::init().with_user();
let model = user.as_model();
let json = user
.update_email_more_control(model.id, Some(""))
.bad_with_status(200);
assert!(
json.errors[0].detail.contains("empty email rejected"),
"{:?}",
json.errors
);
let json = user
.update_email_more_control(model.id, None)
.bad_with_status(200);
assert!(
json.errors[0].detail.contains("empty email rejected"),
"{:?}",
json.errors
);
}
/* Check to make sure that neither other signed in users nor anonymous users can edit another
user's email address.
If an attempt is made, update_user.rs will return an error indicating that the current user
does not match the requested user.
*/
#[test]
fn test_other_users_cannot_change_my_email() {
let (app, anon, user) = TestApp::init().with_user();
let another_user = app.db_new_user("not_me");
let another_user_model = another_user.as_model();
let json = user
.update_email_more_control(
another_user_model.id,
Some("pineapple@pineapples.pineapple"),
)
.bad_with_status(200);
assert!(
json.errors[0]
.detail
.contains("current user does not match requested user",),
"{:?}",
json.errors
);
anon.update_email_more_control(
another_user_model.id,
Some("pineapple@pineapples.pineapple"),
)
.bad_with_status(403);
}
/* Given a new user, test that their email can be added
to the email table and a token for the email is generated
and added to the token table. When /confirm/:email_token is
requested, check that the response back is ok, and that
the email_verified field on user is now set to true.
*/
#[test]
fn test_confirm_user_email() {
use cargo_registry::schema::emails;
let (app, _) = TestApp::init().empty();
// Simulate logging in via GitHub. Don't use app.db_new_user because it inserts a verified
// email directly into the database and we want to test the verification flow here.
let user = app.db(|conn| {
let u = NewUser {
email: Some("potato2@example.com"),
..new_user("arbitrary_username")
};
let u = u.create_or_update(conn).unwrap();
MockCookieUser::new(&app, u)
});
let user_model = user.as_model();
let email_token = app.db(|conn| {
Email::belonging_to(user_model)
.select(emails::token)
.first::<String>(&*conn)
.unwrap()
});
user.confirm_email(&email_token);
let json = user.show_me();
assert_eq!(json.user.email.unwrap(), "potato2@example.com");
assert!(json.user.email_verified);
assert!(json.user.email_verification_sent);
}
/* Given a user who existed before we added email confirmation,
test that `email_verification_sent` is false so that we don't
make the user think we've sent an email when we haven't.
*/
#[test]
fn test_existing_user_email() {
use cargo_registry::schema::emails;
use chrono::NaiveDateTime;
use diesel::update;
let (app, _) = TestApp::init().empty();
// Simulate logging in via GitHub. Don't use app.db_new_user because it inserts a verified
// email directly into the database and we want to test the verification flow here.
let user = app.db(|conn| {
let u = NewUser {
email: Some("potahto@example.com"),
..new_user("arbitrary_username")
};
let u = u.create_or_update(conn).unwrap();
update(Email::belonging_to(&u))
// Users created before we added verification will have
// `NULL` in the `token_generated_at` column.
.set(emails::token_generated_at.eq(None::<NaiveDateTime>))
.execute(conn)
.unwrap();
MockCookieUser::new(&app, u)
});
let json = user.show_me();
assert_eq!(json.user.email.unwrap(), "potahto@example.com");
assert!(!json.user.email_verified);
assert!(!json.user.email_verification_sent);
}