repository URLs sometimes end in .git in real-world usage #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kivikakk
changed the title
|
Looks great, thank you! Sorry for the delay!! bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Nov 29, 2017
1170: repository URLs sometimes end in .git in real-world usage r=carols10cents And this is okay, because the major sites (BitBucket, GitHub, GitLab) all either directly support visiting the `.git`-suffixed URL of any repo, or redirect from it to the non-suffixed version. These all work fine as-is. What they don't universally work for is letting you append any path onto that. (Which is to say, from my testing BitBucket doesn't mind, but GitHub and GitLab both 404.) So we trim the suffix when manipulating relative paths. See clap-rs/clap#1106 for where this came up with `clap`.
|
Not at all, real life happens! |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And this is okay, because the major sites (BitBucket, GitHub, GitLab) all either directly support visiting the
.git-suffixed URL of any repo, or redirect from it to the non-suffixed version. These all work fine as-is.What they don't universally work for is letting you append any path onto that. (Which is to say, from my testing BitBucket doesn't mind, but GitHub and GitLab both 404.) So we trim the suffix when manipulating relative paths.
See clap-rs/clap#1106 for where this came up with
clap.