Reject publishing of crates that depend on an alternative registry #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrif
reviewed
Jan 9, 2019
src/models/dependency.rs
Outdated
| @@ -80,6 +80,12 @@ pub fn add_dependencies( | |||
| let git_and_new_dependencies = deps | |||
| .iter() | |||
| .map(|dep| { | |||
| if let Some(registry) = &dep.registry { | |||
| if !registry.is_empty() { | |||
| return Err(human(&format_args!("Dependency `{}` is from an alternative registry. Depending on alternative registries is not allowed on crates.io.", &*dep.name))); | |||
There was a problem hiding this comment.
What do you think about this wording instead?
Dependency `{}` is hosted on another registry. Cross-registry dependencies are not permitted on crates.io
jtgeibel
force-pushed
the
deny-alt-registry-deps
branch
from
2360837
to
0b606ae
Compare
|
LGTM once the test failure is fixed |
jtgeibel
force-pushed
the
deny-alt-registry-deps
branch
from
0b606ae
to
4df95a2
Compare
|
@bors r+ |
|
📌 Commit 4df95a2 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 21, 2019
Reject publishing of crates that depend on an alternative registry See also #1579 and rust-lang/crates-io-cargo-teams#21.
|
☀️ Test successful - checks-travis |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #1579 and rust-lang/crates-io-cargo-teams#21.