Don't make duplicated requests through Ember Data

[kzys]

ember-data-storefront provides FastbootAdapter which caches XHRs in
Fastboot's Shoebox.

This will prevent duplicated requests on /crates and other
Ember Data-powered pages.

[rust-highfive]

r? @smarnach

(rust_highfive has picked a reviewer for you, use r? to override)

[jtgeibel]

Based on some concerns raised on Discord, lets reassign.

r? @locks

[kzys]

From Discord:

@kzys I asked for second opinions on #2087 and I think we shouldn't bring in ember-data-storefront just for this

I don't have strong opinion on ember-data-storefront. If we don't want to add the package, can we inject fetch() into RESTAdapter instead? I'm not so sure how hard it would be.

https://github.com/emberjs/data/blob/94aef4dd61d8697636d23631441c19ff96e38f65/packages/adapter/addon/rest.js#L1057

[kzys]

Ping @locks?

[locks]

Looking into it today!

[bors]

☔ The latest upstream changes (presumably #2122) made this pull request unmergeable. Please resolve the merge conflicts.

[kzys]

@locks We could inject something that queries Fastboot's Shoebox on adapters by having our own initializer, but Ember's Adapter API doesn't provide a good hook point which we can utilize. Both ajax and _ajaxRequest are declared as private.

https://api.emberjs.com/ember-data/3.4/classes/DS.RESTAdapter?show=private

Surprisingly even ember-cli-fastboot is overriding _ajaxRequest.

https://github.com/ember-fastboot/ember-cli-fastboot/blob/6a5d6c6e38c30e5afda20db34de2ff5745b1416f/fastboot/initializers/ajax.js#L33

[kzys]

@locks - I'd like to hear your thoughts if you have some time.

[locks]

Sorry, busy days lately. If I can't address this by Monday I will step out of the way.

[kzys]

I have removed ember-data-storefront on the last revision.

[kzys]

@jtgeibel @smarnach - Can you take a look since @locks is busy?

[jtgeibel]

@kzys I had some trouble testing this in my staging area at https://jtgeibel-staging-crates-io.herokuapp.com/. (This PR is currently deployed there with USE_FASTBOOT=staging-experimental.) I was running into issues on both master and this branch.

So I focused on getting a better local environment set up. I've opened #2215 and I've got things working there now. I'd like to do a bit more testing, but this PR seems to work well for me locally (with and without fastboot) when merged with this PR.

I'm not sure what the issue with staging-experimental is when deployed to Heroku. In that environment I think maybe the requests from the fastboot server to the backend are being routed in a strange way. I'm not sure if they are going directly to the backend, locally through nginx, or externally through the Heroku router.

[kzys]

I'm not sure if they are going directly to the backend, locally through nginx, or externally through the Heroku router.

Hmm, I think it should be directly request the backend, but I'm not 100% sure.

[locks]

I just found out about https://github.com/cardstack/ember-data-fastboot, which should help with the boilerplate.

[bors]

☔ The latest upstream changes (presumably #2290) made this pull request unmergeable. Please resolve the merge conflicts.

[kzys]

@locks It is somewhat coupled with JSONAPISerializer, which we don't use.

Right now, this addon assumes that your application is using DS.JSONAPISerializer as your application's default serialization method.

[kzys]

I cannot keep up with all the refactorting the team is doing. Ping me once that is over...

[Turbo87]

In #7301 we've removed most of the unused fastboot code, since it doesn't really seem well supported by Ember.js these days. Since this PR is building on top of fastboot, I'll close it for now. Thank you for your work anyway! :)