Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ember-keyboard 6.0.0 #2563

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Update to ember-keyboard 6.0.0 #2563

merged 1 commit into from
Jun 10, 2020

Conversation

lukemelia
Copy link
Contributor

@lukemelia lukemelia commented Jun 10, 2020 •
edited
Loading

  • refactor to new template helpers
  • add config flag to avoid deprecation warning about initializer

@lukemelia
Update to ember-keyboard 6.0.0
520ef37 
- refactor to new template helpers
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @locks (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Turbo87
Copy link
Member

Turbo87 commented Jun 10, 2020

works great, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jun 10, 2020

📌 Commit 520ef37 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Jun 10, 2020

⌛ Testing commit 520ef37 with merge 34ee91b...

bors added a commit that referenced this pull request Jun 10, 2020
@bors
Auto merge of #2563 - lukemelia:chore/upgrade-ember-keyboard, r=Turbo87
34ee91b 
Update to ember-keyboard 6.0.0

- refactor to new template helpers
- add config flag to avoid deprecation warning about initializer
@bors
Copy link
Contributor

bors commented Jun 10, 2020

💥 Test timed out

@Turbo87
Copy link
Member

Turbo87 commented Jun 10, 2020

what?

@bors retry

@Turbo87
Copy link
Member

Turbo87 commented Jun 10, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 10, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Jun 10, 2020

📌 Commit 520ef37 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Jun 10, 2020

⌛ Testing commit 520ef37 with merge d70e609...

@bors
Copy link
Contributor

bors commented Jun 10, 2020

☀️ Test successful - checks-travis
Approved by: Turbo87
Pushing d70e609 to master...

@bors bors merged commit d70e609 into rust-lang:master Jun 10, 2020
@lukemelia lukemelia deleted the chore/upgrade-ember-keyboard branch June 15, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@locks locks

Labels
A-frontend 🐹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lukemelia @rust-highfive @Turbo87 @bors @locks