Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing line breaks for crate name and refine sidebar layout #3600

Merged
merged 2 commits into from May 16, 2021
Merged

Fix missing line breaks for crate name and refine sidebar layout #3600

merged 2 commits into from May 16, 2021

Conversation

Unbinilium
Copy link
Contributor

Notified that crates.io seems not optimized for small screen devices while I was finding crates on my phone, some long crate names made the website in a mess due to missing line breaks, in my opinion a simple workaround would apply to it by adding line breaks.

Test on my laptop with Safari 14.1:

  • Add overflow wrap to the names of crates

    1

  • Add word-break to the header name and no-readme texts in detailed crate pages

    2

  • Add word-break to texts inside the sidebar copy button

    3

  • Change the flex layout wrap to column when window width is less than 890px to avoid warp overflow in row

    4

This would not be the best workaround, it only provides a better experience while surfing the crates.io on the phone, on small screen devices or on a split window view.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jtgeibel (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Unbinilium
Copy link
Contributor Author

Fetched upstream commits to test CI build check again

@Turbo87 Turbo87 added A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works labels May 16, 2021
@Turbo87
Copy link
Member

Turbo87 commented May 16, 2021

@Unbinilium thanks for working on this, and sorry for the review delay

one small suggestion for future PRs: if you make four separate changes in the same PR (and in this case even the same commit), they block each other from getting merged if there is a disagreement on one of them, and it also makes it harder on the reviewer to review them because it can be difficult to figure out what code change belongs to which conceptual change. in other words: it would be easier on the reviewer if PRs like this were split up into several commits, or even PRs. if you want to read up some more on this I recommend having a look at https://google.github.io/eng-practices/review/developer/small-cls.html :)

@bors r+

@bors
Copy link
Contributor

bors commented May 16, 2021

📌 Commit 8c8df51 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented May 16, 2021

⌛ Testing commit 8c8df51 with merge bb048e2...

@bors
Copy link
Contributor

bors commented May 16, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing bb048e2 to master...

@bors bors merged commit bb048e2 into rust-lang:master May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants