Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versions: Adjust checksum column to be NOT NULL #5135

Merged
merged 1 commit into from Aug 29, 2022
Merged

versions: Adjust checksum column to be NOT NULL #5135

merged 1 commit into from Aug 29, 2022

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Aug 28, 2022

Now that we have run the import script, all of our versions in the database have a non-null checksum field. This PR adjusts the column to be a NOT NULL column to avoid having to unnecessarily deal with Option<_> for this field.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Aug 28, 2022
@Turbo87
Copy link
Member Author

Turbo87 commented Aug 28, 2022

/cc @arlosi

arlosi
arlosi approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@arlosi arlosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Turbo87 Turbo87 merged commit 561abba into rust-lang:master Aug 29, 2022
@Turbo87 Turbo87 deleted the non-null-checksum branch August 29, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlosi arlosi arlosi approved these changes

Assignees
No one assigned
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Turbo87 @arlosi