Implement CrateScope struct
#5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Turbo87
commented
Dec 1, 2022
| } | ||
|
|
||
| pub fn matches(&self, crate_name: &str) -> bool { | ||
| let canonicalize = |name: &str| name.replace('-', "_"); |
There was a problem hiding this comment.
for further discussion: do we want this canonicalization? or do we want the users to be precise?
|
this feature is experimental. so while there is still an open question, we can adjust that later and still merge the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #5568, this PR implements a
CrateScopestruct, which we use for thecrate_scopescolumn of the API tokens database table. It also includes amatches()method to verify whether it matches a crate name or not.Related: