Extract crate_downloads table
#8232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8232 +/- ##
=======================================
Coverage 87.72% 87.73%
=======================================
Files 272 272
Lines 27317 27345 +28
=======================================
+ Hits 23965 23992 +27
- Misses 3352 3353 +1 ☔ View full report in Codecov by Sentry. |
LawnGnome
approved these changes
Mar 4, 2024
eth3lbert
reviewed
Mar 4, 2024
eth3lbert
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Should we expand the test data for crates and their versions to ensure we are updating the correct one?
There was a problem hiding this comment.
I guess that would generally make sense. Since that was already a problem with the existing code I don't want to conflate that with the purpose of this PR though :)
eth3lbert
approved these changes
Mar 4, 2024
…wnloads` table too This is not removing the `crates` table update just yet, since we need to keep both tables in sync for now until the rest of the code is migrated to reading from the `crate_downloads` table instead.
Turbo87
force-pushed
the
crate-downloads-table
branch
from
95e6863
to
fdf1407
Compare
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first in a sequence of multiple PRs that move the
crates.downloadscolumn to a dedicated database table.Whenever we update the
crates.downloadscolumn a full new row is written by Postgres, which causes a lot of churn for the columns in this table that don't actually change that much. We've been seeing quite a few performance issues lately that are supposedly (partially) caused by this behavior.This PR adds a database migration which creates a new
crate_downloadstable, with a commented out query in the migration script to fill the table with the current values. The migration also adds an insert trigger on thecratestable to ensure a correspondingcrate_downloadsrow is automatically created for all newly inserted crates. Deletion of crates is automatically handled byon delete cascade.The PR also adjusts the
update_downloadsbackground job to update bothcrates.downloadsandcrate_downloads.downloadsfor now. We can remove thecrates.downloadsupdates once we switch the backend endpoint to read from thecrate_downloadstable instead.