Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port categories::sync over to use Diesel #903

Merged
merged 8 commits into from Aug 12, 2017
Merged

Port categories::sync over to use Diesel #903

merged 8 commits into from Aug 12, 2017

Conversation

sgrif
Copy link
Contributor

@sgrif sgrif commented Jul 23, 2017

I've changed this to do the whole thing in one insert rather than one
per category.

@sgrif sgrif requested a review from carols10cents July 23, 2017 17:19
@sgrif
Port categories::sync over to use Diesel
13bf9cd 
I've changed this to do the whole thing in one insert rather than one
per category.
carols10cents
carols10cents requested changes Aug 9, 2017
View reviewed changes
Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running this deleted all my categories :( i would like it to not do that plz

@sgrif
Don't delete all categories
1da15a6 
The opposite of `= ANY` is `!= ALL` /facepalm
@sgrif
Copy link
Contributor Author

sgrif commented Aug 10, 2017

Sorry about that. Fixed

@carols10cents
Copy link
Member

thanks!! i made some tests for you toooooo

@carols10cents
Copy link
Member

bors: r+

bors-voyager bot added a commit that referenced this pull request Aug 12, 2017
@bors-voyager
Merge #903
d04d395 
903: Port `categories::sync` over to use Diesel r=carols10cents

I've changed this to do the whole thing in one insert rather than one
per category.
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Aug 12, 2017

Build failed

@carols10cents
Copy link
Member

bors: r+

bors-voyager bot added a commit that referenced this pull request Aug 12, 2017
@bors-voyager
Merge #903
7545f47 
903: Port `categories::sync` over to use Diesel r=carols10cents

I've changed this to do the whole thing in one insert rather than one
per category.
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Aug 12, 2017

Build succeeded

@bors-voyager bors-voyager bot merged commit 7ac79bf into rust-lang:master Aug 12, 2017
@sgrif sgrif deleted the sg-port-categories-sync branch August 13, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carols10cents carols10cents carols10cents approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgrif @carols10cents @Turbo87