Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Cargo.toml package info seems out-of-date #1030

Closed
camelid opened this issue Sep 3, 2020 · 13 comments · Fixed by #1039
Closed

meta: Cargo.toml package info seems out-of-date #1030

camelid opened this issue Sep 3, 2020 · 13 comments · Fixed by #1039
Assignees
Labels
A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute C-enhancement Category: This is a new feature E-easy Effort: Should be easy to implement and would make a good first PR

Comments

@camelid
Copy link
Member

camelid commented Sep 3, 2020

I don't know if this is intentional, but the name of the docs.rs crate is still cratesfyi and the author is Onur Aslan:

docs.rs/Cargo.toml

Lines 1 to 4 in 4909906

[package]
name = "cratesfyi"
version = "0.6.0"
authors = ["Onur Aslan <onuraslan@gmail.com>"]

Shouldn't the name be docs-rs or something and the author be The Rust Project Developers like with the rustc crates?

@jyn514
Copy link
Member

jyn514 commented Sep 3, 2020

This would be a good first PR :)

@jyn514
Copy link
Member

jyn514 commented Sep 3, 2020

Oh - but please leave the name of the binary as cratesfyi, or we'll have to change all the scripts in prod.

@jyn514 jyn514 added A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute E-easy Effort: Should be easy to implement and would make a good first PR C-enhancement Category: This is a new feature labels Sep 3, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 3, 2020

See also #244.

@camelid

This comment has been minimized.

@rustbot

This comment has been minimized.

@jyn514
Copy link
Member

jyn514 commented Sep 3, 2020

Hmm ... @rust-lang/docs-rs how do you feel about changing the authors field in all the packages to The Rust Project Developers or something similar? That's what rustc does: https://github.com/rust-lang/rust/blob/7dfbf59f100c52e991796739ff21b9720219703f/compiler/rustc/Cargo.toml#L2

@pietroalbini
Copy link
Member

I'd add "The Rust Project Developers" in addition to Onur. They still created the project, and that should be credited.

@camelid
Copy link
Member Author

camelid commented Sep 4, 2020

So something like this then?

authors = ["Onur Aslan <...>", "The Rust Project Developers"]

(And the same sort of change for the inner crates.)

Rustfmt does it that way, but has The Rustfmt developers as the second author. Should we do The docs.rs Developers or go with The Rust Project Developers? Personally I think it might be better to go with The Rust Project Developers since we're all part of the Rust project and so it's the same authors.

@jyn514
Copy link
Member

jyn514 commented Sep 4, 2020

I like "The Rust Project Developers" but I don't feel strongly about it.

@Kixiron
Copy link
Member

Kixiron commented Sep 6, 2020

Wouldn't this be a good place to use the Docs.rs Team?

@pietroalbini
Copy link
Member

I think "The Rust Project Developers" is the most appropriate here.

@camelid
Copy link
Member Author

camelid commented Sep 7, 2020

Opened #1039.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute C-enhancement Category: This is a new feature E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants