Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the remaining mentions of cratesfyi to docs-rs, docs_rs or similar. #244

Open
eddyb opened this issue Oct 19, 2018 · 4 comments
Open

Rename the remaining mentions of cratesfyi to docs-rs, docs_rs or similar. #244

eddyb opened this issue Oct 19, 2018 · 4 comments
Labels
A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-medium Effort: This requires a fair amount of work P-low Low priority issues

Comments

@eddyb
Copy link
Member

eddyb commented Oct 19, 2018

No description provided.

@jyn514 jyn514 added the wishlist label Feb 1, 2020
@jyn514 jyn514 added E-medium Effort: This requires a fair amount of work A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute P-low Low priority issues and removed wishlist labels Jun 27, 2020
@Nemo157
Copy link
Member

Nemo157 commented Jul 18, 2020

Also, there's an inconsistency between some environment variables being DOCS_RS_* and others being DOCSRS_*, would be good to standardize these.

@jyn514 jyn514 added the C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users label Jul 18, 2020
@alb
Copy link

alb commented Jul 18, 2020

Which one should be used? Is it DOCS_RS_* or DOCSRS_*?

@jyn514
Copy link
Member

jyn514 commented Jul 18, 2020

I don't have a strong preference. I think more uses DOCS_RS currently so let's go with that.

@Nemo157
Copy link
Member

Nemo157 commented Jul 18, 2020 •
edited

I think it's actually the opposite

> rg --hidden '(DOCSRS|DOCS_RS)_[A-Z_]+' --only-matching --no-heading --no-filename --no-line-number | LC_ALL=C sort -u
DOCSRS_BUILD_ATTEMPTS
DOCSRS_MAX_FILE_SIZE
DOCSRS_MAX_FILE_SIZE_HTML
DOCSRS_MAX_POOL_SIZE
DOCSRS_MIN_POOL_IDLE
DOCS_RS_BUILD_CPU_LIMIT
DOCS_RS_DOCKER
DOCS_RS_LOCAL_DOCKER_IMAGE

@jyn514 jyn514 mentioned this issue Sep 3, 2020
Closed
This was referenced Apr 17, 2021
Merged
Merged
@jyn514 jyn514 mentioned this issue Jun 24, 2021
Closed
@jyn514 jyn514 mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-newcomer-roadblock Area: A problem that isn't a bug, but makes it harder for people to contribute C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-medium Effort: This requires a fair amount of work P-low Low priority issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all traces of cratesfyi (to the extent possible) jyn514/docs.rs
4 participants
@eddyb @Nemo157 @jyn514 @alb