retry toolchain update, only lock queue after 3 failed attempts #1789
Conversation
github-actions
bot
added
the
S-waiting-on-review
There shouldn't be, it's using |
|
@Nemo157 is anything missing here? I'm happy to add what's needed |
| } | ||
| } | ||
| } | ||
| unreachable!() |
There was a problem hiding this comment.
nit: you could avoid this by using loop instead of for
src/build_queue.rs
Outdated
| @@ -188,6 +188,27 @@ impl BuildQueue { | |||
| } | |||
| } | |||
|
|
|||
| fn retry<T>(mut f: impl FnMut() -> Result<T>) -> Result<T> { | |||
| const MAX_ATTEMPTS: u8 = 3; | |||
There was a problem hiding this comment.
If you're going to make retry reusable, I would expect this to be a function parameter.
| for attempt in 1.. { | ||
| match f() { |
There was a problem hiding this comment.
this retries immediately, right? shouldn't we wait between requests?
There was a problem hiding this comment.
Valid point 😄
( funny I didn't think of that, must have been a case of nightly blackout 😂)
There was a problem hiding this comment.
I added exponential sleep between the tries
syphar
force-pushed
the
retry-toolchain-update
branch
from
4fc5afe
to
0f68a98
Compare
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This is a simple attempt at solving #1787.
Since I don't know details about
update_toolchain: are there any possible errors that might leave the toolchain in a broken state where a retry would make it worse?