Upload docker image to dev ecr repo #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Mark-Simulacrum
approved these changes
Jan 11, 2023
jyn514
approved these changes
Jan 11, 2023
rylev
force-pushed
the
upload-to-ecr-dev
branch
from
f874100
to
5f9a94d
Compare
syphar
reviewed
Jan 11, 2023
syphar
added
S-waiting-on-review
|
( I don't want to slow down the ECS / docs.rs story I would also merge this and then add back our tests later) |
syphar
approved these changes
Jan 12, 2023
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the creation of the docs-rs-staging environment, we can now deploy master to the environment. We may want to be a bit smarter about this to allow for more targeted testing, but for now this can let me test that the environment works.