Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toml #2092

Closed
wants to merge 1 commit into from
Closed

Update toml #2092

wants to merge 1 commit into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 2, 2023

Combined with rust-lang/rustwide#77, this will remove a duplicate version of toml.

Combined with a PR to rustwide, this will remove a duplicate version of
toml.
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Apr 2, 2023
@syphar
Copy link
Member

syphar commented Apr 3, 2023

Thank you for investing time on this!

Seeing that there are test failures I assume this has to wait for the rustwide change to be merged & released? Or something less is wrong?

@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Apr 3, 2023
@jyn514
Copy link
Member Author

jyn514 commented Apr 3, 2023

I think there was some breaking change in toml I need to fix, it's not related to rustwide.

@Nemo157
Copy link
Member

Nemo157 commented May 31, 2023

It looks like toml::to_string now deals in only full documents, to serialize fragments like we do you need to use https://docs.rs/toml/latest/toml/ser/struct.ValueSerializer.html

@syphar
Copy link
Member

syphar commented Jun 18, 2023

superseded by #2156

@syphar syphar closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants