Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store & show build logs for non-default targets #2427

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Feb 28, 2024

fixes #787.

Generally the idea is:

  • we store additional logs next to the default-target logs
  • the build-details view just shows all files in that folder

Due to lack of web frontend skills I just added a barely functional way to switch through the logs, I would appreciate help here, though I would also be fine with merging the interface as-is.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Feb 28, 2024
@syphar syphar force-pushed the target-build-logs branch 2 times, most recently from 2343bdc to 022fd7a Compare February 28, 2024 13:04
@syphar
Copy link
Member Author

syphar commented Feb 28, 2024

triggered by the discussion in #2424 I was looking into what's actually missing to solve this issue and more specifically, if it depends on #1011.

In the end, it was easier than I thougth.

@syphar syphar marked this pull request as ready for review February 28, 2024 13:06
@syphar syphar requested a review from a team as a code owner February 28, 2024 13:06
@syphar
Copy link
Member Author

syphar commented Feb 28, 2024

Interface in this PR would look like:
grafik

@syphar
Copy link
Member Author

syphar commented Feb 29, 2024

@Nemo157 btw, I think this could also be improved by showing a build-status per target, but I definitely wanted to postpone until after #1011

@Nemo157
Copy link
Member

Nemo157 commented Feb 29, 2024

I was wondering if we could just use "is the filename in the releases.doc_targets list" as a proxy for that till we actually track it. But either way better to do in a separate PR.

@syphar syphar merged commit e486388 into rust-lang:master Feb 29, 2024
7 checks passed
@syphar syphar deleted the target-build-logs branch February 29, 2024 15:45
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Feb 29, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record build logs for non-default targets
2 participants