Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2018-specific changes. #130

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 11, 2018

Closes #91.

@ehuss
Copy link
Contributor Author

ehuss commented Dec 11, 2018

Some notes:

  • I have no idea where to place the page. I just stuck it at the end. Another option would be to place it directly in rust-2018/index.md but that didn't quite feel right.
  • This is intentionally terse since it is intended to just be an overview. I'd be happy to add more detail, examples, links, etc. if you want.
  • I'd be fine with dropping the Cargo section. The changes are relatively minor, and Cargo gives plenty of warnings in both editions.
  • Feel free to suggest anything. This is the information I want to see, but I understand that the style/voice differs from the rest of the guide.
  • I'll try to keep this list updated in the future. Some of these are actively being moved to 2015, and things like async/await will likely need to be added.

src/rust-2018/edition-changes.md Outdated Show resolved Hide resolved
src/rust-2018/edition-changes.md Outdated Show resolved Hide resolved
src/SUMMARY.md Outdated Show resolved Hide resolved
@ehuss
Copy link
Contributor Author

ehuss commented Dec 11, 2018

Good points, thanks for taking a look!

@dwijnand
Copy link
Member

This would be lovely to land, it took me quite some digging before I realised that NLL is edition 2018 only.

As a side note, I couldn't figure out how to specify the edition to rustc because it's not in rustc --help or in the guide anywhere, so I ended up looking it up in the cargo sources. (I later found it in rustc --help -v.)

@steveklabnik steveklabnik merged commit 783d13f into rust-lang:master Jan 10, 2019
@steveklabnik
Copy link
Member

Thank you! People have been asking about this for a while. I think this is a fine place to put it, we can iterate if it turns out to be not ideal in practice.

@dwijnand
Copy link
Member

Now that Rust nightly is fixed, could someone rerun the merge build for this so it deploys, please? Thank you!

https://travis-ci.com/rust-lang-nursery/edition-guide/builds/96925518

@ehuss
Copy link
Contributor Author

ehuss commented Jan 15, 2019

I poked it, but it looks like it will be queued for a long time due to other jobs running. Oops, nevermind.

@dwijnand
Copy link
Member

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 28, 2019
Update edition-guide

15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e
2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800
- Migrate to mdbook 0.2. (rust-lang/edition-guide#152)
- Remove automatic deployment. (rust-lang/edition-guide#151)
- Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147)
- Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148)
- overflowing_literals is deny on all editions (rust-lang/edition-guide#146)
- Update for uniform_path stabilization. (rust-lang/edition-guide#141)
- Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144)
- Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142)
- Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137)
- Add 2018-specific changes. (rust-lang/edition-guide#130)
- aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125)
- Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124)
- update several version numbers
- Fixes outdated link (rust-lang/edition-guide#131)
- Fixed typo in transitioning page. (rust-lang/edition-guide#127)
bors added a commit to rust-lang/rust that referenced this pull request Mar 1, 2019
Update edition-guide

15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e
2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800
- Migrate to mdbook 0.2. (rust-lang/edition-guide#152)
- Remove automatic deployment. (rust-lang/edition-guide#151)
- Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147)
- Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148)
- overflowing_literals is deny on all editions (rust-lang/edition-guide#146)
- Update for uniform_path stabilization. (rust-lang/edition-guide#141)
- Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144)
- Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142)
- Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137)
- Add 2018-specific changes. (rust-lang/edition-guide#130)
- aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125)
- Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124)
- update several version numbers
- Fixes outdated link (rust-lang/edition-guide#131)
- Fixed typo in transitioning page. (rust-lang/edition-guide#127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants