transitioning: specify behavior in workspace #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
comes from rust-av/rust-av#62 |
Centril
reviewed
Aug 14, 2018
| @@ -112,3 +112,11 @@ the warnings, that's a bug! | |||
|
|
|||
| Once you're warning-free with this command you're good to go. Enjoy the new | |||
| edition! | |||
There was a problem hiding this comment.
I would move this new bit up over "Once you're warning-free with this command you're good to go. Enjoy the new edition!" so that "Enjoy the new edition!" is the last thing a user reads here.
| @@ -112,3 +112,11 @@ the warnings, that's a bug! | |||
|
|
|||
| Once you're warning-free with this command you're good to go. Enjoy the new | |||
| edition! | |||
|
|
|||
| The `--edition-idioms` flag applies only to the "current crate" if you want | |||
There was a problem hiding this comment.
Maybe highlight this as an aside? "Note that the --edition-idioms..."?
gibix
force-pushed
the
workspace-idioms
branch
from
eef1f74
to
4105902
Compare
|
thanks for the feedback! |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.