Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV raised to 1.34.0 in 1.0.10-11 #207

Closed
dekellum opened this issue Aug 15, 2019 · 1 comment
Closed

MSRV raised to 1.34.0 in 1.0.10-11 #207

dekellum opened this issue Aug 15, 2019 · 1 comment

Comments

@dekellum
Copy link

This is minimally just and FYI for maintainers and users, if MSRV bumps such as this in patch releases are considered acceptable here.

When compiling with rust rustc 1.28.0 (9634041f0 2018-07-30) 1.28.0-x86_64-unknown-linux-gnu:

error[E0658]: access to extern crates through prelude is experimental (see issue #44660)
  --> /home/david/.cargo/registry/src/github.com-1ecc6299db9ec823/flate2-1.0.11/src/ffi.rs:96:26
   |
96 |     const ALIGN: usize = std::mem::align_of::<usize>();
   |                          ^^^

error[E0658]: access to extern crates through prelude is experimental (see issue #44660)
   --> /home/david/.cargo/registry/src/github.com-1ecc6299db9ec823/flate2-1.0.11/src/ffi.rs:111:41
    |
111 |             .and_then(|i| i.checked_add(std::mem::size_of::<usize>()))
    |                                         ^^^

error[E0658]: access to extern crates through prelude is experimental (see issue #44660)
   --> /home/david/.cargo/registry/src/github.com-1ecc6299db9ec823/flate2-1.0.11/src/ffi.rs:388:30
    |
388 |         pub type AllocSize = libc::size_t;
    |                              ^^^^

error[E0658]: use of unstable library feature 'try_from' (see issue #33417)
  --> /home/david/.cargo/registry/src/github.com-1ecc6299db9ec823/flate2-1.0.11/src/ffi.rs:47:9
   |
47 |     use std::convert::TryFrom;
   |         ^^^^^^^^^^^^^^^^^^^^^

error[E0658]: use of unstable library feature 'try_from' (see issue #33417)
   --> /home/david/.cargo/registry/src/github.com-1ecc6299db9ec823/flate2-1.0.11/src/ffi.rs:109:27
    |
109 |             .and_then(|i| usize::try_from(i).ok())
    |                           ^^^^^^^^^^^^^^^

error: aborting due to 5 previous errors

With rust 1.31.0-x86_64-unknown-linux-gnu:

error[E0658]: use of unstable library feature 'try_from' (see issue #33417)                                                             
  --> /home/david/.cargo/registry/src/github.com-1ecc6299db9ec823/flate2-1.0.11/src/ffi.rs:47:9                                         
   |                                                                                                                                    
47 |     use std::convert::TryFrom;                                                                                                     
   |         ^^^^^^^^^^^^^^^^^^^^^                                                                                                      
                                                                                                                                        
   Compiling parking_lot v0.7.1                                                                                                         
error[E0658]: use of unstable library feature 'try_from' (see issue #33417)                                                             
   --> /home/david/.cargo/registry/src/github.com-1ecc6299db9ec823/flate2-1.0.11/src/ffi.rs:109:27                                      
    |                                                                                                                                   
109 |             .and_then(|i| usize::try_from(i).ok())                                                                                
    |                           ^^^^^^^^^^^^^^^                                                                                         

Where std::convert::TryFrom isn't stable until rust 1.34.0.

If instead I downgrade to 1.0.9, then it compiles with rust 1.28.0 (and possibly lower).

dekellum added a commit to dekellum/tokio that referenced this issue Aug 15, 2019
flate2 1.0.10-11 have MSRV 1.34.0.

github refs: rust-lang/flate2-rs#207
@alexcrichton
Copy link
Member

Thanks for the report! This crate supports the current stable and last stable for the latest version, so this is intended. If you'd like to send a PR though to build on older versions such a PR is always welcome!

LucioFranco pushed a commit to tokio-rs/tokio that referenced this issue Aug 15, 2019
* use dyn Trait syntax where appropriate

recent rust nightly started warning that not using `dyn` was
deprecated. This requires MSRV 1.27.0+.

* rustfmt fallout from dyn additions

* stop explicit allow of rust_2018_idioms

* more dyn Trait syntax

* drop tokio-macros from 0.1.x workspace

Since tokio-macros specifies an edition=2018, we would otherwise
require MSRV 1.31.0 to build/test it. And tokio-macros isn't used with
tokio 0.1.x.

* reactor: narrow tokio-io-pool dev dep to 0.1.4

Since 0.1.5-6 is now a edition=2018 crate, which has effective MSRV
1.31.0.

* narrow tempfile dev-dep to avoid MSRV bump

tempfile 3.1.0 pulls in rand 0.7.0 and is MSRV 1.32.0

* narrow flate2 dev-dep to avoid MSRV bump

flate2 1.0.10-11 have MSRV 1.34.0.

github refs: rust-lang/flate2-rs#207

* fs: drop deprecated tempdir crate use in tests

In particular because it pulls in old rand duplicates. Replace use
with tempfile::tempdir() which has been available since tempfile
3.0.0.

backport-of: #1312

* increase CI MSRV to 1.28.0
danieldk added a commit to stickeritis/sticker that referenced this issue Aug 17, 2019
danieldk added a commit to stickeritis/sticker that referenced this issue Aug 17, 2019
dekellum added a commit to dekellum/body-image that referenced this issue Sep 25, 2019
flate2 1.0.10-11 have MSRV 1.34.0.

github refs: rust-lang/flate2-rs#207
toTheMoon0322 added a commit to toTheMoon0322/TOKIO that referenced this issue May 22, 2024
* use dyn Trait syntax where appropriate

recent rust nightly started warning that not using `dyn` was
deprecated. This requires MSRV 1.27.0+.

* rustfmt fallout from dyn additions

* stop explicit allow of rust_2018_idioms

* more dyn Trait syntax

* drop tokio-macros from 0.1.x workspace

Since tokio-macros specifies an edition=2018, we would otherwise
require MSRV 1.31.0 to build/test it. And tokio-macros isn't used with
tokio 0.1.x.

* reactor: narrow tokio-io-pool dev dep to 0.1.4

Since 0.1.5-6 is now a edition=2018 crate, which has effective MSRV
1.31.0.

* narrow tempfile dev-dep to avoid MSRV bump

tempfile 3.1.0 pulls in rand 0.7.0 and is MSRV 1.32.0

* narrow flate2 dev-dep to avoid MSRV bump

flate2 1.0.10-11 have MSRV 1.34.0.

github refs: rust-lang/flate2-rs#207

* fs: drop deprecated tempdir crate use in tests

In particular because it pulls in old rand duplicates. Replace use
with tempfile::tempdir() which has been available since tempfile
3.0.0.

backport-of: #1312

* increase CI MSRV to 1.28.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants