-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSRV raised to 1.34.0 in 1.0.10-11 #207
Comments
dekellum
added a commit
to dekellum/tokio
that referenced
this issue
Aug 15, 2019
flate2 1.0.10-11 have MSRV 1.34.0. github refs: rust-lang/flate2-rs#207
Thanks for the report! This crate supports the current stable and last stable for the latest version, so this is intended. If you'd like to send a PR though to build on older versions such a PR is always welcome! |
LucioFranco
pushed a commit
to tokio-rs/tokio
that referenced
this issue
Aug 15, 2019
* use dyn Trait syntax where appropriate recent rust nightly started warning that not using `dyn` was deprecated. This requires MSRV 1.27.0+. * rustfmt fallout from dyn additions * stop explicit allow of rust_2018_idioms * more dyn Trait syntax * drop tokio-macros from 0.1.x workspace Since tokio-macros specifies an edition=2018, we would otherwise require MSRV 1.31.0 to build/test it. And tokio-macros isn't used with tokio 0.1.x. * reactor: narrow tokio-io-pool dev dep to 0.1.4 Since 0.1.5-6 is now a edition=2018 crate, which has effective MSRV 1.31.0. * narrow tempfile dev-dep to avoid MSRV bump tempfile 3.1.0 pulls in rand 0.7.0 and is MSRV 1.32.0 * narrow flate2 dev-dep to avoid MSRV bump flate2 1.0.10-11 have MSRV 1.34.0. github refs: rust-lang/flate2-rs#207 * fs: drop deprecated tempdir crate use in tests In particular because it pulls in old rand duplicates. Replace use with tempfile::tempdir() which has been available since tempfile 3.0.0. backport-of: #1312 * increase CI MSRV to 1.28.0
danieldk
added a commit
to stickeritis/sticker
that referenced
this issue
Aug 17, 2019
danieldk
added a commit
to stickeritis/sticker
that referenced
this issue
Aug 17, 2019
dekellum
added a commit
to dekellum/body-image
that referenced
this issue
Sep 25, 2019
flate2 1.0.10-11 have MSRV 1.34.0. github refs: rust-lang/flate2-rs#207
This was referenced Dec 23, 2022
Merged
toTheMoon0322
added a commit
to toTheMoon0322/TOKIO
that referenced
this issue
May 22, 2024
* use dyn Trait syntax where appropriate recent rust nightly started warning that not using `dyn` was deprecated. This requires MSRV 1.27.0+. * rustfmt fallout from dyn additions * stop explicit allow of rust_2018_idioms * more dyn Trait syntax * drop tokio-macros from 0.1.x workspace Since tokio-macros specifies an edition=2018, we would otherwise require MSRV 1.31.0 to build/test it. And tokio-macros isn't used with tokio 0.1.x. * reactor: narrow tokio-io-pool dev dep to 0.1.4 Since 0.1.5-6 is now a edition=2018 crate, which has effective MSRV 1.31.0. * narrow tempfile dev-dep to avoid MSRV bump tempfile 3.1.0 pulls in rand 0.7.0 and is MSRV 1.32.0 * narrow flate2 dev-dep to avoid MSRV bump flate2 1.0.10-11 have MSRV 1.34.0. github refs: rust-lang/flate2-rs#207 * fs: drop deprecated tempdir crate use in tests In particular because it pulls in old rand duplicates. Replace use with tempfile::tempdir() which has been available since tempfile 3.0.0. backport-of: #1312 * increase CI MSRV to 1.28.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is minimally just and FYI for maintainers and users, if MSRV bumps such as this in patch releases are considered acceptable here.
When compiling with rust rustc 1.28.0 (9634041f0 2018-07-30) 1.28.0-x86_64-unknown-linux-gnu:
With rust 1.31.0-x86_64-unknown-linux-gnu:
Where
std::convert::TryFrom
isn't stable until rust 1.34.0.If instead I downgrade to 1.0.9, then it compiles with rust 1.28.0 (and possibly lower).
The text was updated successfully, but these errors were encountered: