Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mentioning of default spawners from docs #1757

Closed
SrTobi opened this issue Jul 21, 2019 · 4 comments · Fixed by #1944
Closed

Remove mentioning of default spawners from docs #1757

SrTobi opened this issue Jul 21, 2019 · 4 comments · Fixed by #1944
Milestone
0.3 release

Comments

@SrTobi
Copy link
Contributor

SrTobi commented Jul 21, 2019

The docs mention default spawners multiple times in the LocalPool/ThreadPool docs (see below) but from what I understand they do not exist anymore as no spawner is passed along the poll chain (see c5e5fd5) anymore.

It is very confusing to read something about default spawner when they don't exists.

https://github.com/rust-lang-nursery/futures-rs/blob/a705910a8d844f6d56527ab9d774be09eb3008d5/futures-executor/src/local_pool.rs#L106
https://github.com/rust-lang-nursery/futures-rs/blob/a705910a8d844f6d56527ab9d774be09eb3008d5/futures-executor/src/local_pool.rs#L129
https://github.com/rust-lang-nursery/futures-rs/blob/a705910a8d844f6d56527ab9d774be09eb3008d5/futures-executor/src/local_pool.rs#L140

https://github.com/rust-lang-nursery/futures-rs/blob/a705910a8d844f6d56527ab9d774be09eb3008d5/futures-executor/src/thread_pool.rs#L86

https://github.com/rust-lang-nursery/futures-rs/blob/a705910a8d844f6d56527ab9d774be09eb3008d5/futures-executor/src/thread_pool.rs#L91
@SrTobi SrTobi changed the title Remove mentioning of default spawners from docs or double down on them Remove mentioning of default spawners from docs Jul 21, 2019
@SrTobi SrTobi mentioned this issue Jul 21, 2019
Closed
@SrTobi
Copy link
Contributor Author

SrTobi commented Jul 21, 2019

I would have made a PR but I think it's wiser to decide on #1758 first.

@cramertj
Copy link
Member

I think both this and #1758 are correct and I would like to include them in the 0.3 release.

@cramertj cramertj added this to the 0.3 release milestone Oct 30, 2019
@SrTobi
Copy link
Contributor Author

SrTobi commented Nov 2, 2019

Does that mean you want me to do the pr or will you do it yourself?

@cramertj
Copy link
Member

cramertj commented Nov 4, 2019

I'll land one today.

cramertj added a commit to cramertj/futures-rs that referenced this issue Nov 5, 2019
@cramertj
Remove ThreadPool::run and mentions of default spawners
c851801 
Fixes rust-lang#1757
Fixes rust-lang#1758
@cramertj cramertj mentioned this issue Nov 5, 2019
Merged
cramertj added a commit that referenced this issue Nov 5, 2019
@cramertj
Remove ThreadPool::run and mentions of default spawners
ac81046 
Fixes #1757
Fixes #1758
exrook pushed a commit to exrook/futures-rs that referenced this issue Apr 5, 2021
@cramertj
Remove ThreadPool::run and mentions of default spawners
a3ddfef 
Fixes rust-lang#1757
Fixes rust-lang#1758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3 release
Development

Successfully merging a pull request may close this issue.

Remove ThreadPool::run and mentions of default spawners cramertj/futures-rs
2 participants
@SrTobi @cramertj