Remove try_ready! macro #1602
Merged
Remove try_ready! macro #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pollimplements theTrytrait, so we can use the?operator andready!macro to do the equivalent oftry_ready!macro.Actually,
ready!+?operator is more powerful thantry_ready!because it also can be used in functions that returnPoll<Option<Result>>. (Also,Result+?can be used in functions that returnPoll<Result>andPoll<Option<Result>>as well.)I think it is not a problem to remove
try_ready!, and it may also rather increase code consistency.Related: #1599, #1572