Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat wrapper methods #1705

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Compat wrapper methods #1705

merged 1 commit into from
Jul 7, 2019

Conversation

VictorKoenders
Copy link
Contributor

Made sure the Compat01As03 and Compat03As01 wrappers have the following methods:

  • get_ref
  • get_mut
  • into_inner

Closes #1704

@VictorKoenders
Copy link
Contributor Author

The pipeline itself seems to time out:

creating directory /home/travis/.cache/sccache
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

@taiki-e
Copy link
Member

taiki-e commented Jul 3, 2019

@VictorKoenders Could you rebase? I think the issue of ci was fixed by 08dfdc6.

@VictorKoenders
Copy link
Contributor Author

Rebased onto master (I think, someone double check that for me, git is arcane)

Copy link
Member

@Nemo157 Nemo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cramertj cramertj merged commit b9ba5d4 into rust-lang:master Jul 7, 2019
@VictorKoenders VictorKoenders deleted the into_inner_methods branch July 11, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compat into_inner methods
4 participants