async LineWriter fix #2131
#2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having trouble on handling |
taiki-e
reviewed
Aug 21, 2021
doing so saves me thinking on how to deal with pin and fields
- translate `std::io::LineWriter`'s unit test - rename `inner` field to `buf_writer` to avoid confusion with `BufWriter::inner` - the above lead me to re-write the logic accordingly - add methods to access `buf_writer`'s fields - sorting out types, cannot compile for now
FelipeLema
commented
Aug 24, 2021
- default `poll_write_vectored` behaves differently of `std::io::LineWriter::write_vectored` - ported from https://github.com/rust-lang/rust/blob/673d0db5e393e9c64897005b470bfeb6d5aec61b/library/std/src/io/buffered/tests.rs - that code has lots of comments, you may wanna check it out - translated tests for `std` 's `line_vectored` - added `inner_poll_write_vectored` to keep code explicit and verbose
|
I didn't finish porting the last unit test, but it should be good as it is right now. I rather not keep this going on for too long Maybe someone else will add it in the near future. |
taiki-e
added
0.3-backport: pending
taiki-e
pushed a commit
that referenced
this pull request
Nov 23, 2021
Merged
taiki-e
added
0.3-backport: completed
and removed
0.3-backport: pending
taiki-e
pushed a commit
that referenced
this pull request
Nov 23, 2021
taiki-e
pushed a commit
that referenced
this pull request
Nov 23, 2021
Merged
|
Published in 0.3.18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2131
This is based on
std::io::LineWriterand itsLineWriterShimsidekick