Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync 0.3 branch #2802

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Sync 0.3 branch #2802

merged 1 commit into from
Nov 20, 2023

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Nov 20, 2023

@edef1c @taiki-e
FillBuf: don't poll a second time on EOF
871ab07 
There is no hard guarantee that polling a second time will return
Poll::Ready, and this is particularly likely to break in the EOF case,
which is precisely where we don't need to do so at all.

Both tokio::io::BufReader and futures::io::BufReader always attempt to
read from the underlying reader when the buffer is empty, rather than
fusing EOF.
@taiki-e taiki-e mentioned this pull request Nov 20, 2023
Merged
@taiki-e taiki-e merged commit ae3297f into master Nov 20, 2023
25 checks passed
@taiki-e taiki-e deleted the 0.3-sync branch November 20, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taiki-e @edef1c