Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Float16 and Float128 support for jit #47

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Add Float16 and Float128 support for jit #47

merged 1 commit into from
Apr 7, 2024

Conversation

zedar
Copy link

@zedar zedar commented Apr 3, 2024

This PR is part of a broader rust-lang/rustc_codegen_gcc#461

antoyo
antoyo reviewed Apr 3, 2024
View reviewed changes
Copy link

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mostly good. A few things to adjust.
Thanks!

gcc/jit/jit-recording.cc Outdated Show resolved Hide resolved
gcc/jit/jit-playback.cc Outdated Show resolved Hide resolved
gcc/jit/libgccjit.h Outdated Show resolved Hide resolved
@zedar
Copy link
Author

zedar commented Apr 3, 2024

Added support for _Float32 and _Float64

@zedar zedar marked this pull request as ready for review April 3, 2024 20:19
@antoyo
Copy link

antoyo commented Apr 4, 2024 •
edited

Thanks!

Could you please update this test to add the checks for these new types?
And please also add these new types to the docs.

Add _Float16, _Float32, _Float64 and __float128 support for jit
ff2800a 
Fix _Float16 and __float128 support for jit. Add _Float32 and _Float64 support for jit

Add Float32 and Float54, update test-types.c
@zedar zedar force-pushed the support_for_f16_and_f128_types branch from 47c63d3 to ff2800a Compare April 5, 2024 14:19
@zedar
Copy link
Author

zedar commented Apr 6, 2024

Thanks!

Could you please update this test to add the checks for these new types? And please also add these new types to the docs.

Done

@antoyo antoyo merged commit ab469a6 into rust-lang:master Apr 7, 2024
2 checks passed
@antoyo
Copy link

antoyo commented Apr 7, 2024

Thanks for your contribution!

@antoyo antoyo mentioned this pull request Apr 7, 2024
Open
@zedar zedar mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoyo antoyo antoyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zedar @antoyo