Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support git_repository_set_index #128

Merged
merged 1 commit into from
May 8, 2016
Merged

Please support git_repository_set_index #128

merged 1 commit into from
May 8, 2016

Conversation

joshtriplett
Copy link
Member

libgit2 provides a function git_repository_set_index to set the index of a repository, useful for doing index-based operations without disrupting the current state in .git/index. Please consider providing a git::Repository::set_index function to access that.

@alexcrichton
Copy link
Member

Sure! Bindings basically aren't ever left out intentionally, just haven't gotten around to writing it yet.

@joshtriplett
Copy link
Member Author

I'm not entirely sure if this is the correct type signature. The underlying function definitely needs to mutate the index (setting the owner, specifically). But I see many functions in git2-rs that seem to hide mutation behind a plain & rather than a &mut, including all the Repository functions.

@joshtriplett
Copy link
Member Author

joshtriplett commented May 6, 2016

The Travis failure here looks like some spurious issue with systest, unrelated to this commit. Looking at the log, the testsuite looks like it passed.

@alexcrichton
Copy link
Member

Thanks!

@alexcrichton alexcrichton merged commit d393aef into rust-lang:master May 8, 2016
@joshtriplett joshtriplett deleted the set_index branch May 10, 2016 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants