Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.4.1 and bump versions #811

Merged
merged 1 commit into from Feb 24, 2022
Merged

Conversation

ehuss
Copy link
Collaborator

@ehuss ehuss commented Feb 18, 2022

This updates libgit2 to 1.4.1, and bumps the Cargo versions as a SemVer breaking change.

This also includes a file with instructions on how to do a libgit2 update.

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Feb 22, 2022

IIRC there's a fair bit of cruft along the lines of "remove this deprecated method when the next major version happens" or something like that. I unfortunately haven't been keeping great track of that over time so I don't exactly have a list off-hand. Would you be up for poking around and seeing how much is affected? If you're short on time then I think merging this is fine as well.

@ehuss
Copy link
Collaborator Author

@ehuss ehuss commented Feb 23, 2022

I can nuke all of the deprecated stuff. There's a pretty long list in deprecated.h. Do you care about providing deprecated warnings? That is:

  • Remove anything already marked #[deprecated]
  • Remove anything in libgit-sys that is deprecated in C. I personally don't feel like it is very important to provide deprecation warnings for these, since the number of active users for the raw API is probably close to zero. However, perhaps I am in a surly mood today.
  • Remove anything in the git2 crate that is deprecated, even if not using #[deprecated]. There are a few things like the code for generating email-formatted diffs that has fundamentally changed the API. I could maybe see adding deprecations instead of outright removal, but again I feel like the number of users is extremely small.

I can't think of any API breaking changes that are waiting in the wings so to speak. I skimmed the open and closed PRs, but didn't see anything.

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Feb 24, 2022

Oh I don't mean to cause too much work or anything like that, if we're using deprecated.h that doesn't need to be fixed here. I recall things like foo2 or foo_with_worse_name being added to replace foo because it didn't have a great API or wasn't working for one reason or another, although I'm not sure that these have been tracked with #[deprecated] so it may be pretty manual.

Let's go ahead and merge this and other things can be figured out later

@alexcrichton alexcrichton merged commit 64d849b into rust-lang:master Feb 24, 2022
6 checks passed
@weihanglo
Copy link
Contributor

@weihanglo weihanglo commented Feb 26, 2022

I guess we need to publish a new version of git2-curl. PR is ready: #814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants