Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RawTable publically #104

Closed
hansihe opened this issue Jul 17, 2019 · 2 comments · Fixed by #108
Closed

Expose RawTable publically #104

hansihe opened this issue Jul 17, 2019 · 2 comments · Fixed by #108

Comments

@hansihe
Copy link
Contributor

hansihe commented Jul 17, 2019

I find myself in the need of writing a hash map with some custom ownership semantics in regards to keys.

Your internal RawTable seems to provide exactly the functionality I, with enough flexibility to provide the custom semantics I need.

Would you be open to exposing RawTable publically, possibly behind a feature flag? I do realize that the API most likely is very unstable and may change, but this is something I would be willing to deal with.

@Amanieu
Copy link
Member

Amanieu commented Jul 17, 2019

Could you give a bit more detail regarding the ownership semantics for your hash map?

I'm somewhat open to the idea, but the current RawTable API isn't very user-friendly.

@garro95
Copy link

garro95 commented Jul 27, 2019

I would also like it, to have direct (unsafe) access to the entries by index.
The objective would be to replace the current IndexMap used inside my PriorityQueue and remove one level of indirection that I don't need.

bors added a commit that referenced this issue Aug 4, 2019
Experimentally expose RawTable under the "raw" feature

Fixes #104
@bors bors closed this as completed in #108 Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants