Introduce ahash-compile-time-rng feature.
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ndorio
force-pushed
the
allow_to_disable_ahash_feature
branch
from
3fe2350
to
2907d9b
Compare
|
Clippy seems to be failing due to a new lint. Could you add Also, could you document the feature in |
Disables the default features of `ahash` and reintroduces them through a new feature called `ahash-compile-time-rng`, which is enabled by default. The new feature makes it possible for depended crates to rely on `hashbrown` with `ahash` as default hasher and to disable the `compile-time-rng` at the same time. This might be useful for any dependent crate targeting `no_std`, which contains `rand` or `rand_core` somewhere inside the dependency tree as a bug in cargo accidentally enables the underlying `getrandom` feature if `compile-time-rng` is enabled [1]. ... fixes rust-lang#124 [1] rust-lang/cargo#5760
0ndorio
force-pushed
the
allow_to_disable_ahash_feature
branch
from
2907d9b
to
43911e5
Compare
Added new commit to fix this.
Amended the documentation to the original commit. |
0ndorio
force-pushed
the
allow_to_disable_ahash_feature
branch
from
43911e5
to
388287c
Compare
|
You need to run |
0ndorio
force-pushed
the
allow_to_disable_ahash_feature
branch
from
388287c
to
92bc9f8
Compare
|
@bors r+ |
|
📌 Commit 92bc9f8 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 31, 2019
Introduce `ahash-compile-time-rng` feature. **Content** Disables the default features of `ahash` and reintroduces them through a new feature called `ahash-compile-time-rng`, which is enabled by default. The new feature makes it possible for depended crates to rely on `hashbrown` with `ahash` as default hasher and to disable the `compile-time-rng` at the same time. This might be useful for any depended crate targeting `no_std`, which contains `rand` or `rand_core` somewhere inside the dependency tree as a bug in cargo accidentally enables the underlying `getrandom` feature if `compile-time-rng` is enabled [1]. ... fixes #124 [1] rust-lang/cargo#5760 --- **Warnings** (1) Compiling `ahash` with disabled `compile-time-rng` feature is currently broken and requires tkaitchuck/aHash#25 to be merged in advance. (2) This introduces a hidden behavior change for all dependent crates, using hashbrown with `default-features = false` and `features = 'ahash'`. This happens as the `ahash` feature no longer implicitly enables the `compile-time-rng` feature of `ahash`. --- Is the naming of the feature okay? Do I need to add any additional changes?
|
☀️ Test successful - checks-travis |
This was referenced Nov 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Disables the default features of
ahashand reintroduces themthrough a new feature called
ahash-compile-time-rng, which isenabled by default.
The new feature makes it possible for depended crates to rely on
hashbrownwithahashas default hasher and to disable thecompile-time-rngat the same time.This might be useful for any depended crate targeting
no_std,which contains
randorrand_coresomewhere inside the dependencytree as a bug in cargo accidentally enables the underlying
getrandomfeature if
compile-time-rngis enabled [1].... fixes #124
[1] rust-lang/cargo#5760
Warnings
(1) Compiling
ahashwith disabledcompile-time-rngfeature is currently broken and requires tkaitchuck/aHash#25 to be merged in advance.(2) This introduces a hidden behavior change for all dependent crates, using hashbrown with
default-features = falseandfeatures = 'ahash'. This happens as theahashfeature no longer implicitly enables thecompile-time-rngfeature ofahash.Is the naming of the feature okay? Do I need to add any additional changes?