Specialize fold implementation of iterators
#480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides 5-8% iteration speedups
JustForFun88
reviewed
Nov 8, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 9, 2023
`HashMap`/`HashSet`: forward `fold` implementations of iterators Use [rust-lang/hasbrown#480](rust-lang/hashbrown#480) in `std`
Amanieu
reviewed
Nov 16, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2024
`HashMap`/`HashSet`: forward `fold` implementations of iterators Use [rust-lang/hasbrown#480](rust-lang/hashbrown#480) in `std` Note: this needs a version bump of hashbrown before merging
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 21, 2024
`HashMap`/`HashSet`: forward `fold` implementations of iterators Use [rust-lang/hasbrown#480](rust-lang/hashbrown#480) in `std` Note: this needs a version bump of hashbrown before merging
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
`HashMap`/`HashSet`: forward `fold` implementations of iterators Use [rust-lang/hasbrown#480](rust-lang/hashbrown#480) in `std` Note: this needs a version bump of hashbrown before merging
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
`HashMap`/`HashSet`: forward `fold` implementations of iterators Use [rust-lang/hasbrown#480](rust-lang/hashbrown#480) in `std` Note: this needs a version bump of hashbrown before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides 5-8% iteration speedups when using internal iteration.
Similar work could probably be done with
try_foldbut this requiresnightlyto implement.Maybe this is worth running a rustc perf run with this before merge ?