Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Respond with a reviewer to all PRs #3

Closed
nrc opened this issue Sep 21, 2014 · 2 comments
Closed

Respond with a reviewer to all PRs #3

nrc opened this issue Sep 21, 2014 · 2 comments

Comments

@nrc
Copy link
Member

nrc commented Sep 21, 2014

Highfive currently just responds to PRs from new contributors (it checks for unsafe code in all PRs, but that is separate to this issue). I propose that if a PR has r? @some_user, highfive change the assignee to some_user (note this will silently fail if some_user is not a valid assignee). If there is no proposed reviewer, Highfive will select one, ping them, and set the assignee. If the PR is from a new contributor, Highfive will use the welcome message.
@nrc
Copy link
Member Author

nrc commented Oct 2, 2014

The behaviour described above for the case where the user specifies a reviewer is implemented in 5dd7ba8

@nrc
Copy link
Member Author

nrc commented Dec 15, 2014

This is fixed locally, but I'm having GitHub issues getting this to show up in the repo.

@nrc nrc closed this as completed Dec 15, 2014
nrc added a commit that referenced this issue Dec 19, 2014
@nrc
Always suggest a reviewer if the author doesn't
150b1d0 
Closes #3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nrc