Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Give some changes back to Servo's highfive #35

Open
nrc opened this issue Jan 14, 2015 · 6 comments
Open

Give some changes back to Servo's highfive #35

nrc opened this issue Jan 14, 2015 · 6 comments

Comments

@nrc
Copy link
Member

nrc commented Jan 14, 2015

This project was originally a fork of jdm/highfive, used for Servo. I removed a few things, changed a few things, and since then we've added a lot. It would be nice if we could push some of the additions back to Servo land. Perhaps the easiest was to do that is to expand this version to cover the stuff removed or changed and then persuade them to switch (or just push everything back to jdm's original fork). I fear taking our changes and adding them to the original would be a tricky job.

cc @jdm

@jdm
Copy link
Contributor

jdm commented Jan 14, 2015

Integrating a bunch of the changes here has been on my TODO list for a while. Making the relevant github comments configurable would be useful.

@flaper87
Copy link
Contributor

@nick29581 @jdm Do we have a list of these differences feature-wise between the original project and this fork?

I can diff both repos but I figured it'd be nice to document there here and find a way to make highfive pluggable.

@nrc
Copy link
Member Author

nrc commented Jan 20, 2015

No, and there are a lot of changes

@flaper87
Copy link
Contributor

just checked the original repo. It looks like besides the custom messages, this fork has support for the features in the original repo.

@nrc
Copy link
Member Author

nrc commented Jan 20, 2015

There are at least unsafe warnings, which are currently commented out for Rust (too many false positives)

@flaper87
Copy link
Contributor

Ok, I'll tackle this issue. I'll work on making highfive more configurable and pluggable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants