This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub (now) has an endpoint to check if a user is a collaborator. Currently, Highfive uses the list collaborators endpoint and then checks the response to see if the expected user is there. I assume this response is subject to being paginated in projects with lots of collaborators. Highfive, however, isn't handling pagination in this case. I don't know if that's an issue (i.e., I don't know how many contributors rust-lang/rust has; a problem would manifest as Highfive ignoring "r? @" comments from some collaborators), but it seems like an issue waiting to happen.
This PR modifies Highfive to check if a specific user is a reviewer.
In addition to the unit tests, I manually verified that
is_collaborator
is working as expected. Here's the log of that:Here is some justification for caution: I haven't tested this on a Highfive instance running against a repository. (I'm working on this now, but I keep accidentally opening my PR here. Rather than closing this again and making more noise, I am just going to update this comment when I'm done.)