Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bors sometimes tests a different commit than what got approved #215

Open
RalfJung opened this issue Mar 23, 2024 · 0 comments
Open

Bors sometimes tests a different commit than what got approved #215

RalfJung opened this issue Mar 23, 2024 · 0 comments

Comments

@RalfJung
Copy link
Member

This looks like a race condition: In rust-lang/miri#3399, I did bors r+, then I did a force push, then the tests started.

Commit rust-lang/miri@9dfd214 has been approved by RalfJung

Testing commit rust-lang/miri@00f700d with merge rust-lang/miri@bf1e82f...

Note how it is testing a different commit than what got approved! No idea how that is possible, I thought it would store in a database "commit X got approved" and then it will only ever test that commit.
@RalfJung RalfJung changed the title Bors sometimes tests a different commit than what got imrpvoed Bors sometimes tests a different commit than what got approved Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RalfJung