Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

critical: a try build can trigger a merge to master #47

Open
bryanburgers opened this issue Jun 12, 2019 · 3 comments
Open

critical: a try build can trigger a merge to master #47

bryanburgers opened this issue Jun 12, 2019 · 3 comments

Comments

@bryanburgers
Copy link
Contributor

It appears that sometimes, the result of a try build can trigger a merge to master. This seems to occur when the PR is approved between when the try build is started and when the Homu gets notified that the try build finished.

See: rust-lang/rust#61763 (comment)

Potential steps to reproduce (haven't tried this yet, but it fits with what happened on the referenced issue comment):

  1. Start a try build (e.g. @botname try)
  2. Approve the build (e.g. @botname r+)
  3. Wait until the try build succeeds
@kennytm
Copy link
Member

kennytm commented Jun 12, 2019

Sounds like #3 in the other direction. Perhaps disallow r+ when state is pending && try?

@RalfJung
Copy link
Member

I think this is what caused the buggy toolchain yesterday? Cc rust-lang/rust#113713

@RalfJung
Copy link
Member

Sounds like the dual issue to #214.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants