Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix ci stats upload condition #61763

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
7 participants
@pietroalbini
Copy link
Member

commented Jun 12, 2019

The condition I suggested in #61632 was not correct and it errors out while evaluating. This fixes the condition. Example of a failure.

r? @alexcrichton

@pietroalbini

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

Let's see if the condition actually works before merging.

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

⌛️ Trying commit dbb5d80 with merge 03fce13...

bors added a commit that referenced this pull request Jun 12, 2019

Auto merge of #61763 - pietroalbini:azure-fix-condition, r=<try>
ci: fix ci stats upload condition

The condition I suggested in #61632 was not correct and it errors out while evaluating. This fixes the condition. [Example of a failure](https://dev.azure.com/rust-lang/rust/_build/results?buildId=543).

r? @alexcrichton
Show resolved Hide resolved .azure-pipelines/steps/run.yml Outdated
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

☀️ Try build successful - checks-travis
Build commit: 03fce13

ci: fix ci stats upload condition
The condition I suggested in #61632 was not correct and it errors out
while evaluating. This fixes the condition.

Example of a failure:
https://dev.azure.com/rust-lang/rust/_build/results?buildId=543

@pietroalbini pietroalbini force-pushed the pietroalbini:azure-fix-condition branch from dbb5d80 to 2cd516c Jun 12, 2019

@pietroalbini

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

⌛️ Trying commit 2cd516c with merge 78e4f00...

bors added a commit that referenced this pull request Jun 12, 2019

Auto merge of #61763 - pietroalbini:azure-fix-condition, r=<try>
ci: fix ci stats upload condition

The condition I suggested in #61632 was not correct and it errors out while evaluating. This fixes the condition. [Example of a failure](https://dev.azure.com/rust-lang/rust/_build/results?buildId=543).

r? @alexcrichton
@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

📌 Commit 2cd516c has been approved by alexcrichton

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@bors: rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

☀️ Test successful - checks-travis
Approved by: alexcrichton
Pushing 78e4f00 to master...

@bors bors added the merged-by-bors label Jun 12, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@lzutao

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@rustbot modify labels: -merged-by-bors

@rustbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 12, 2019

Error: Label merged-by-bors can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@bors: retry

Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019

Rollup merge of rust-lang#61763 - pietroalbini:azure-fix-condition, r…
…=alexcrichton

ci: fix ci stats upload condition

The condition I suggested in rust-lang#61632 was not correct and it errors out while evaluating. This fixes the condition. [Example of a failure](https://dev.azure.com/rust-lang/rust/_build/results?buildId=543).

r? @alexcrichton

bors added a commit that referenced this pull request Jun 12, 2019

Auto merge of #61783 - Centril:rollup-r5u53z7, r=Centril
Rollup of 10 pull requests

Successful merges:

 - #60376 (Stabilize Option::xor)
 - #61398 (Stabilize copy_within)
 - #61629 (Hygienize macros in the standard library)
 - #61675 (Include frame pointer for bare metal RISC-V targets)
 - #61750 (Fix x.py install)
 - #61757 (Deprecate ONCE_INIT)
 - #61762 (rustbuild: fix libtest_stamp)
 - #61763 (ci: fix ci stats upload condition)
 - #61771 (Update cargo)
 - #61776 (Fix typos in error_codes)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019

Rollup merge of rust-lang#61763 - pietroalbini:azure-fix-condition, r…
…=alexcrichton

ci: fix ci stats upload condition

The condition I suggested in rust-lang#61632 was not correct and it errors out while evaluating. This fixes the condition. [Example of a failure](https://dev.azure.com/rust-lang/rust/_build/results?buildId=543).

r? @alexcrichton

bors added a commit that referenced this pull request Jun 13, 2019

Auto merge of #61789 - Centril:rollup-hhyvopq, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #60376 (Stabilize Option::xor)
 - #61398 (Stabilize copy_within)
 - #61629 (Hygienize macros in the standard library)
 - #61675 (Include frame pointer for bare metal RISC-V targets)
 - #61750 (Fix x.py install)
 - #61761 (Add an alias for x86_64-sun-solaris target tuple)
 - #61762 (rustbuild: fix libtest_stamp)
 - #61763 (ci: fix ci stats upload condition)
 - #61776 (Fix typos in error_codes)

Failed merges:

r? @ghost

@bors bors merged commit 2cd516c into rust-lang:master Jun 13, 2019

1 of 2 checks passed

homu Test was successful, but fast-forwarding failed: 422 Update is not a fast forward
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.