Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix ci stats upload condition #61763

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

pietroalbini
Copy link
Member

The condition I suggested in #61632 was not correct and it errors out while evaluating. This fixes the condition. Example of a failure.

r? @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2019
@pietroalbini
Copy link
Member Author

Let's see if the condition actually works before merging.

@bors try

@bors
Copy link
Contributor

bors commented Jun 12, 2019

⌛ Trying commit dbb5d8028f78f57602cadcd049ea0ffe29bad106 with merge 03fce1303c3280a936c43d601968b944409e04f5...

@bors
Copy link
Contributor

bors commented Jun 12, 2019

☀️ Try build successful - checks-travis
Build commit: 03fce1303c3280a936c43d601968b944409e04f5

The condition I suggested in rust-lang#61632 was not correct and it errors out
while evaluating. This fixes the condition.

Example of a failure:
https://dev.azure.com/rust-lang/rust/_build/results?buildId=543
@pietroalbini
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jun 12, 2019

⌛ Trying commit 2cd516c with merge 78e4f00...

bors added a commit that referenced this pull request Jun 12, 2019
ci: fix ci stats upload condition

The condition I suggested in #61632 was not correct and it errors out while evaluating. This fixes the condition. [Example of a failure](https://dev.azure.com/rust-lang/rust/_build/results?buildId=543).

r? @alexcrichton
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 12, 2019

📌 Commit 2cd516c has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2019
@alexcrichton
Copy link
Member

@bors: rollup

@bors
Copy link
Contributor

bors commented Jun 12, 2019

☀️ Test successful - checks-travis
Approved by: alexcrichton
Pushing 78e4f00 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 12, 2019
@bors
Copy link
Contributor

bors commented Jun 12, 2019

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@tesuji
Copy link
Contributor

tesuji commented Jun 12, 2019

@rustbot modify labels: -merged-by-bors

@rustbot
Copy link
Collaborator

rustbot commented Jun 12, 2019

Error: Label merged-by-bors can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@Mark-Simulacrum Mark-Simulacrum removed the merged-by-bors This PR was explicitly merged by bors. label Jun 12, 2019
@alexcrichton
Copy link
Member

@bors: retry

Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019
…=alexcrichton

ci: fix ci stats upload condition

The condition I suggested in rust-lang#61632 was not correct and it errors out while evaluating. This fixes the condition. [Example of a failure](https://dev.azure.com/rust-lang/rust/_build/results?buildId=543).

r? @alexcrichton
Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019
…=alexcrichton

ci: fix ci stats upload condition

The condition I suggested in rust-lang#61632 was not correct and it errors out while evaluating. This fixes the condition. [Example of a failure](https://dev.azure.com/rust-lang/rust/_build/results?buildId=543).

r? @alexcrichton
bors added a commit that referenced this pull request Jun 13, 2019
Rollup of 9 pull requests

Successful merges:

 - #60376 (Stabilize Option::xor)
 - #61398 (Stabilize copy_within)
 - #61629 (Hygienize macros in the standard library)
 - #61675 (Include frame pointer for bare metal RISC-V targets)
 - #61750 (Fix x.py install)
 - #61761 (Add an alias for x86_64-sun-solaris target tuple)
 - #61762 (rustbuild: fix libtest_stamp)
 - #61763 (ci: fix ci stats upload condition)
 - #61776 (Fix typos in error_codes)

Failed merges:

r? @ghost
@bors bors merged commit 2cd516c into rust-lang:master Jun 13, 2019
@pietroalbini pietroalbini deleted the azure-fix-condition branch August 13, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants