Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non_blocking_read signature #81

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix non_blocking_read signature #81

merged 1 commit into from
Apr 12, 2024

Conversation

NobodyXu
Copy link
Contributor

should take mutable reference to buffer.

@NobodyXu
Fix non_blocking_read signature
1529c58 
should take mutable reference to buffer.
@NobodyXu
Copy link
Contributor Author

cc @weihanglo

weihanglo
weihanglo approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weihanglo weihanglo merged commit 36a5e2e into rust-lang:main Apr 12, 2024
14 checks passed
@NobodyXu NobodyXu deleted the patch-1 branch April 12, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobodyXu @weihanglo