Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Update to latest upstream master #1

Closed
wants to merge 6 commits into from

Conversation

Aaron1011
Copy link
Member

This pulls in a fix for ianlancetaylor#32

Update to config.guess 2018-05-19 and config.sub 2018-05-24 from
git://git.savannah.gnu.org/config.git revision
3a2a927f547ee478147008c3fda2adb8a2b2ebc4.

This brings in musl support.
This adds DWARF 5 support as well as an enhanced testsuite.

Patch assembled by Than McIntosh.
This supports FreeBSD and NetBSD when /proc is not mounted.
@alexcrichton
Copy link
Member

I don't believe the master branch of this repository is used, but rather the rust-snapshot-* branch is used by the backtrace crate.

@ghost
Copy link

ghost commented Feb 19, 2020

Rebasing on upstream would also fix rust-lang/rust#54434 which would be nice to see happen.

@Aaron1011
Copy link
Member Author

@alexcrichton: Should I make a pull request merging upstream into rust-snapshot-2018-05-22, or should someone make a newer rust-snapshot branches with the fixes from rust-snapshot-2018-05-22 applied?

@alexcrichton
Copy link
Member

@Aaron1011 I think the best thing to do is to make a new branch based of libbacktrace's master branch, then cherry-pick all the Rust fixes, then show me where the branch is so I can push it up to this repository

@ghost
Copy link

ghost commented Feb 29, 2020

@alexcrichton I have done that here: https://github.com/t6/libbacktrace/tree/rust-snapshot-2020-02-19

I did not really know what to do with the preliminary macho support upstream added. Reading ianlancetaylor#2 (comment) I'm not convinced it is ready so I reverted that commit.

@alexcrichton
Copy link
Member

Thanks @t6! Mind sending a PR to the backtrace crate with this submodule update? That should run CI and see if everything still works, and when that's all ship shape I can push the branch up to this repo.

One worry I'd have is that we do rely on mach-o support in one form or another, but so long as all the tests are passing I think it's fine.

@ghost
Copy link

ghost commented Mar 3, 2020

rust-lang/backtrace-rs#299

@alexcrichton
Copy link
Member

This is now a branch at https://github.com/rust-lang/libbacktrace/tree/rust-snapshot-2020-02-19, so closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants