Simplify the stdbuild section #1019
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @sfackler -- @alexcrichton is currently not available, can you review it instead? |
|
trying next libs team member. This PR shouldnt sit here not being looked at just because alex is gone! r? @BurntSushi |
|
To confirm, this has been tested in the rust-lang/rust repo and it builds successfully? |
|
@alexcrichton yes, I've done that back when I filed the PR. |
|
@bors: r+ |
|
📌 Commit f164aa8 has been approved by |
Simplify the stdbuild section Found this when encountering the code in the rustc submodule and changing the allow for the warnings to deny. * `no_std` is stable so it does not have to be listed in the `feature` attribute * `no_std` as an attribute for the crate is already implied by the `#![cfg_attr(not(feature = "use_std"), no_std)]` below * `staged_api` as an attribute gives a warning. That also matches my knowledge.
|
☀️ Test successful - status-appveyor, status-travis |
Found this when encountering the code in the rustc submodule and changing the allow for the warnings to deny.
no_stdis stable so it does not have to be listed in thefeatureattributeno_stdas an attribute for the crate is already implied by the#![cfg_attr(not(feature = "use_std"), no_std)]belowstaged_apias an attribute gives a warning. That also matches my knowledge.