Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBSD: fix pthread types on arm and powerpc #1108

Merged
merged 6 commits into from Oct 31, 2018

Conversation

jakllsch
Copy link
Contributor

@jakllsch jakllsch commented Oct 28, 2018

No description provided.

Also while here: fix powerpc64, mips, and mips64 pthread types.  These
targets are not yet fully/correctly implemented in rust-libc however.
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Can the cfg_if! declarations be pushed down into submodules instead of being expanded inline?

@jakllsch
Copy link
Contributor Author

@alexcrichton I was able to eliminate all added cfg_if! declarations.

@alexcrichton
Copy link
Member

Thanks! I think the tidy script is failing though?

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 31, 2018

📌 Commit 7cd5d11 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 31, 2018

⌛ Testing commit 7cd5d11 with merge 9525816...

bors added a commit that referenced this pull request Oct 31, 2018
NetBSD: fix pthread types on arm and powerpc
@bors
Copy link
Contributor

bors commented Oct 31, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 9525816 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants