Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RISC-V 64-bit GNU/Linux #1606

Merged
merged 3 commits into from Nov 28, 2019
Merged

Support for RISC-V 64-bit GNU/Linux #1606

merged 3 commits into from Nov 28, 2019

Conversation

@msizanoen1
Copy link
Contributor

msizanoen1 commented Nov 27, 2019

Add support for RISC-V 64-bit GNU/Linux.

Follow up to rust-lang/rust#66661.

r? @alexcrichton

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Nov 27, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@msizanoen1 msizanoen1 force-pushed the msizanoen1:riscv branch from 174e097 to 60eccd5 Nov 27, 2019
Copy link
Collaborator

gnzlbg left a comment

Please add a build job for this target here to make sure that this at least compiles: https://github.com/rust-lang/libc/blob/master/ci/build.sh#L224

You might want to consider taking over #1416 as a follow up (no need to try to do any of that here).

@msizanoen1 msizanoen1 force-pushed the msizanoen1:riscv branch from 60eccd5 to 887d66b Nov 27, 2019
@msizanoen1 msizanoen1 force-pushed the msizanoen1:riscv branch from 887d66b to 112b7f9 Nov 27, 2019
@gnzlbg
gnzlbg approved these changes Nov 27, 2019
Copy link
Collaborator

gnzlbg left a comment

@bors: r+

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 27, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 27, 2019

📌 Commit 112b7f9 has been approved by gnzlbg

@msizanoen1

This comment has been minimized.

Copy link
Contributor Author

msizanoen1 commented Nov 27, 2019

The target specification is not in the latest nightly, only master - even when using rustup update --force.
It looks like we will have to wait for next nightly.

@msizanoen1 msizanoen1 force-pushed the msizanoen1:riscv branch from e2cc0ec to bf419bb Nov 28, 2019
@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 28, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 28, 2019

📌 Commit a06978b has been approved by gnzlbg

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 28, 2019

⌛️ Testing commit a06978b with merge 5130285...

bors added a commit that referenced this pull request Nov 28, 2019
Support for RISC-V 64-bit GNU/Linux

Add support for RISC-V 64-bit GNU/Linux.

Follow up to rust-lang/rust#66661.

r? @alexcrichton
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 28, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 5130285 to master...

@bors bors merged commit a06978b into rust-lang:master Nov 28, 2019
6 checks passed
6 checks passed
homu Test successful
Details
nightly x86_64-unknown-freebsd-10 Task Summary
Details
nightly x86_64-unknown-freebsd-12 Task Summary
Details
rust-lang.libc #20191128.3 succeeded
Details
rust-lang.libc (1) #20191128.3 succeeded
Details
stable x86_64-unknown-freebsd-11 Task Summary
Details
@msizanoen1 msizanoen1 deleted the msizanoen1:riscv branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.