Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl: add missing AArch64 HWCAP_* consts #2172

Merged
merged 1 commit into from
May 14, 2021
Merged

Conversation

tarcieri
Copy link
Contributor

Closes #2171.

I effectively just copied and pasted these from #1638 after confirming that they are identical to musl's aarch64/bits/hwcap.h and that musl's getauxval() also takes a c_ulong.

It seems like if these are added it would address some of TODO-linux.txt?

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Amanieu
Copy link
Member

Amanieu commented May 13, 2021

I think that does address the TODO-linux.txt, you can remove them from this file.

@tarcieri
Copy link
Contributor Author

@Amanieu done

@Amanieu
Copy link
Member

Amanieu commented May 13, 2021

@bors r+

@bors
Copy link
Contributor

bors commented May 13, 2021

📌 Commit 20b2b2c has been approved by Amanieu

bors added a commit that referenced this pull request May 13, 2021
musl: add missing AArch64 HWCAP_* consts

Closes #2171.

I effectively just copied and pasted these from #1638 after confirming that they are identical to musl's [aarch64/bits/hwcap.h](https://github.com/bminor/musl/blob/4433115/arch/aarch64/bits/hwcap.h) and that musl's `getauxval()` also takes a `c_ulong`.

It seems like if these are added it would address some of [`TODO-linux.txt`](https://github.com/rust-lang/libc/blob/ed1399a/libc-test/semver/TODO-linux.txt)?
@bors
Copy link
Contributor

bors commented May 13, 2021

⌛ Testing commit 20b2b2c with merge 393a80d...

@bors
Copy link
Contributor

bors commented May 13, 2021

💔 Test failed - checks-actions

@tarcieri
Copy link
Contributor Author

Build failure looks unrelated

@joshtriplett
Copy link
Member

Let's give it another try:
@bors r+

@bors
Copy link
Contributor

bors commented May 14, 2021

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented May 14, 2021

📌 Commit 20b2b2c has been approved by joshtriplett

@bors
Copy link
Contributor

bors commented May 14, 2021

⌛ Testing commit 20b2b2c with merge 4d4a90e...

bors added a commit that referenced this pull request May 14, 2021
musl: add missing AArch64 HWCAP_* consts

Closes #2171.

I effectively just copied and pasted these from #1638 after confirming that they are identical to musl's [aarch64/bits/hwcap.h](https://github.com/bminor/musl/blob/4433115/arch/aarch64/bits/hwcap.h) and that musl's `getauxval()` also takes a `c_ulong`.

It seems like if these are added it would address some of [`TODO-linux.txt`](https://github.com/rust-lang/libc/blob/ed1399a/libc-test/semver/TODO-linux.txt)?
@joshtriplett
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented May 14, 2021

⌛ Testing commit 20b2b2c with merge ae698a1...

@bors
Copy link
Contributor

bors commented May 14, 2021

💔 Test failed - checks-cirrus-freebsd-11

@bors
Copy link
Contributor

bors commented May 14, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: joshtriplett
Pushing ae698a1 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

musl: HWCAP_* consts missing on aarch64 targets
5 participants