Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AI_* constants to freebdslike platforms. #2485

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

DimitrisJim
Copy link
Contributor

For dragonfly, some of the constants (AI_MASK, AI_V4MAPPED_CFG and AI_DEFAULT) are behind a __BSD_VISIBLE define. What's the best way to handle these?

Header files for dragonfly and freebsd.

For now, I've just added all common names to freebdslike.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@Amanieu
Copy link
Member

Amanieu commented Oct 27, 2021

It's fine to add these as long as they are defined somewhere in the header files.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 27, 2021

📌 Commit a5da2c2 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Oct 28, 2021

⌛ Testing commit a5da2c2 with merge 90ebf43...

@bors
Copy link
Contributor

bors commented Oct 28, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 90ebf43 to master...

@bors bors merged commit 90ebf43 into rust-lang:master Oct 28, 2021
@DimitrisJim DimitrisJim deleted the freebsd_ai_consts branch October 28, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants