Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added _SC_HOST_NAME_MAX for FreeBSD, DragonFly, BitRig and Linux (glibc and musl) #275

Merged
merged 1 commit into from May 4, 2016

Conversation

raphaelcohn
Copy link
Contributor

I'd have liked to also add NetBSD and OpenBSD, but I can't find where _SC_HOST_NAME_MAX is defined.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@semarie
Copy link
Contributor

semarie commented May 4, 2016

For OpenBSD and NetBSD, it is defined in unistd.h:
http://bxr.su/search?defs=_SC_HOST_NAME_MAX

@raphaelcohn
Copy link
Contributor Author

Ta. I've produced a second pr.
On 4 May 2016 11:14 a.m., "Sebastien Marie" notifications@github.com
wrote:

For OpenBSD and NetBSD, it is defined in unistd.h:
http://bxr.su/search?defs=_SC_HOST_NAME_MAX


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#275 (comment)

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented May 4, 2016

📌 Commit f365111 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 4, 2016

⌛ Testing commit f365111 with merge fc9a7de...

bors added a commit that referenced this pull request May 4, 2016
Added _SC_HOST_NAME_MAX for FreeBSD, DragonFly, BitRig and Linux (glibc and musl)

I'd have liked to also add NetBSD and OpenBSD, but I can't find where _SC_HOST_NAME_MAX is defined.
@bors
Copy link
Contributor

bors commented May 4, 2016

☀️ Test successful - status-appveyor, travis

@bors bors merged commit f365111 into rust-lang:master May 4, 2016
@raphaelcohn raphaelcohn deleted the SC_HOSTNAME_MAX branch May 6, 2016 12:55
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
Add a document with contribution guidelines

This gives us a place to point new contributors, as well as to document
our project practices.
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants