Initial fixes for linux x32 #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ Thanks! |
|
@bors: r+ ...? |
|
@bors: r+ |
|
📌 Commit dbe6d2e has been approved by |
|
☔ The latest upstream changes (presumably #811) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thanks! I think this may need a rebase though now? |
|
Rebased. All green. |
|
@bors: r+ |
|
📌 Commit a5bd4b5 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 19, 2017
Initial fixes for linux x32 Tested with a local build of rustc. The main test can be compiled but fails to execute (receives SIGTRAP, which I think in this case indicates memory violation, I will open an issue in the rustc repo). This PR is important because it fixes the definition of `c_long` and `c_ulong`. Without these fixes, rustc crash with the error: ``` Cannot emit physreg copy instruction UNREACHABLE executed at /checkout/src/llvm/lib/Target/X86/X86InstrInfo.cpp:5778! ``` Related rust-lang/rust#37976
|
💔 Test failed - status-travis |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Oct 19, 2017
Initial fixes for linux x32 Tested with a local build of rustc. The main test can be compiled but fails to execute (receives SIGTRAP, which I think in this case indicates memory violation, I will open an issue in the rustc repo). This PR is important because it fixes the definition of `c_long` and `c_ulong`. Without these fixes, rustc crash with the error: ``` Cannot emit physreg copy instruction UNREACHABLE executed at /checkout/src/llvm/lib/Target/X86/X86InstrInfo.cpp:5778! ``` Related rust-lang/rust#37976
|
💔 Test failed - status-travis |
|
@bors: retry
…On Thu, Oct 19, 2017 at 11:21 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/libc/builds/290050601?utm_source=github_status&utm_medium=notification>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#812 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PjcY46JjaJPefgt7xrLbe_8Y-Lzks5st3cFgaJpZM4P-Vcq>
.
|
bors
added a commit
that referenced
this pull request
Oct 19, 2017
Initial fixes for linux x32 Tested with a local build of rustc. The main test can be compiled but fails to execute (receives SIGTRAP, which I think in this case indicates memory violation, I will open an issue in the rustc repo). This PR is important because it fixes the definition of `c_long` and `c_ulong`. Without these fixes, rustc crash with the error: ``` Cannot emit physreg copy instruction UNREACHABLE executed at /checkout/src/llvm/lib/Target/X86/X86InstrInfo.cpp:5778! ``` Related rust-lang/rust#37976
|
☀️ Test successful - status-appveyor, status-travis |
CryZe
added a commit
to CryZe/time
that referenced
this pull request
May 7, 2018
As indicated by rust-lang/libc#812 the x32 ABI specifies the tv_nsec field as i64 instead of c_long. With this PR the time crate now successfully builds with the x86_64-unknown-linux-gnux32 target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with a local build of rustc. The main test can be compiled but fails to execute (receives SIGTRAP, which I think in this case indicates memory violation, I will open an issue in the rustc repo).
This PR is important because it fixes the definition of
c_longandc_ulong. Without these fixes, rustc crash with the error:Related rust-lang/rust#37976