Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ucreds #867

Merged
merged 3 commits into from
Dec 8, 2017
Merged

Ucreds #867

merged 3 commits into from
Dec 8, 2017

Conversation

Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Dec 7, 2017

I'm not positive on the SOCKCREDSIZE() implementation, but we'll see what CI says I guess.

@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 7, 2017

Hmm, it looks like I imported things wrong. Can someone provide some guidance on how I can safely use core::mem::size_of in my types here?

Removes a compilation warning
@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 7, 2017

Just fixed FreeBSD, so hopefully that passes CI now, but I'm not certain why nightly was failing, maybe some change in module path names?

@alexcrichton
Copy link
Member

The documentation build is slightly different, there's a few other examples throughout of importing mem (it's a bit of a hack right now...)

@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 8, 2017

I dug around enough to know something weird was going on, but didn't quite understand it, so I was hoping for some more details in your response as it didn't give me any new information. Anyways, I hacked around at it a bit more and I think what I've got now is right. We'll see what CI says.

@Susurrus
Copy link
Contributor Author

Susurrus commented Dec 8, 2017

Sweet, that worked!

@Susurrus Susurrus mentioned this pull request Dec 8, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 8, 2017

📌 Commit 35992f2 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 8, 2017

⌛ Testing commit 35992f2 with merge 9d6115a...

bors added a commit that referenced this pull request Dec 8, 2017
Ucreds

I'm not positive on the `SOCKCREDSIZE()` implementation, but we'll see what CI says I guess.
@bors
Copy link
Contributor

bors commented Dec 8, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 9d6115a to master...

@bors bors merged commit 35992f2 into rust-lang:master Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants