Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdimf #93

Merged
merged 4 commits into from
Jul 14, 2018
Merged

fdimf #93

merged 4 commits into from
Jul 14, 2018

Conversation

jackmott
Copy link
Contributor

closes #47

@jackmott
Copy link
Contributor Author

I've also removed the isnanf function and use core::f32/v64 is_nan() instead

@japaric
Copy link
Member

japaric commented Jul 14, 2018

LGTM but needs to be rebased. After rebasing please leave a comment with the text "bors r=japaric" without the quotes to put this in the bors queue.

bors delegate+

@bors
Copy link
Contributor

bors bot commented Jul 14, 2018

✌️ jackmott can now approve this pull request

@jackmott
Copy link
Contributor Author

bors r=japaric

@bors
Copy link
Contributor

bors bot commented Jul 14, 2018

Canceled

@jackmott
Copy link
Contributor Author

bors r=japaric

bors bot added a commit that referenced this pull request Jul 14, 2018
@bors @jackmott
Merge #93
a7e4e25 
93: fdimf r=japaric a=jackmott

closes #47 

Co-authored-by: Jack Mott <jack.mott@gmail.com>
@japaric
Copy link
Member

japaric commented Jul 14, 2018

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 14, 2018

Merge conflict (retrying...)

bors bot added a commit that referenced this pull request Jul 14, 2018
@bors @jackmott
Merge #93
a9e0c4f 
93: fdimf r=japaric a=jackmott

closes #47 

Co-authored-by: Jack Mott <jack.mott@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 14, 2018

Build succeeded

@bors bors bot merged commit ec6c86c into rust-lang:master Jul 14, 2018
@jackmott jackmott mentioned this pull request Jul 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement fdimf
2 participants
@jackmott @japaric