Skip to content

Commit

Permalink
[GlobalISel] Bail on G_PHI narrowing of odd types (PR48188)
Browse files Browse the repository at this point in the history
The current narrowing code for G_PHI can only handle the case
where the size is a multiple of the narrow size. If this is not
the case, fall back to SDAG instead of asserting.

Original patch by shepmaster.

Differential Revision: https://reviews.llvm.org/D92446
  • Loading branch information
nikic committed Mar 1, 2021
1 parent 8a7661e commit 40618a2
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
5 changes: 5 additions & 0 deletions llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,11 @@ LegalizerHelper::LegalizeResult LegalizerHelper::narrowScalar(MachineInstr &MI,
Observer.changedInstr(MI);
return Legalized;
case TargetOpcode::G_PHI: {
// FIXME: add support for when SizeOp0 isn't an exact multiple of
// NarrowSize.
if (SizeOp0 % NarrowSize != 0)
return UnableToLegalize;

unsigned NumParts = SizeOp0 / NarrowSize;
SmallVector<Register, 2> DstRegs(NumParts);
SmallVector<SmallVector<Register, 2>, 2> SrcRegs(MI.getNumOperands() / 2);
Expand Down
27 changes: 27 additions & 0 deletions llvm/test/CodeGen/AArch64/pr48188.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc -O0 -mtriple=aarch64-unknown-linux-gnu < %s | FileCheck %s

; GlobalISel cannot legalize this phi, so we fall back to SDAG.
define void @test() nounwind {
; CHECK-LABEL: test:
; CHECK: // %bb.0: // %entry
; CHECK-NEXT: sub sp, sp, #16 // =16
; CHECK-NEXT: mov x1, xzr
; CHECK-NEXT: mov x0, x1
; CHECK-NEXT: str x1, [sp] // 8-byte Folded Spill
; CHECK-NEXT: str x0, [sp, #8] // 8-byte Folded Spill
; CHECK-NEXT: b .LBB0_1
; CHECK-NEXT: .LBB0_1: // %loop
; CHECK-NEXT: // =>This Inner Loop Header: Depth=1
; CHECK-NEXT: ldr x0, [sp, #8] // 8-byte Folded Reload
; CHECK-NEXT: ldr x1, [sp] // 8-byte Folded Reload
; CHECK-NEXT: str x1, [sp] // 8-byte Folded Spill
; CHECK-NEXT: str x0, [sp, #8] // 8-byte Folded Spill
; CHECK-NEXT: b .LBB0_1
entry:
br label %loop

loop:
%p = phi i72 [ 0, %entry ], [ %p, %loop ]
br label %loop
}

0 comments on commit 40618a2

Please sign in to comment.