Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fixes for aarch64-pc-windows-msvc #46

Merged
merged 2 commits into from
May 5, 2020
Merged

Backport fixes for aarch64-pc-windows-msvc #46

merged 2 commits into from
May 5, 2020

Commits on Apr 1, 2020

  1. [AArch64] Fix mismatch in prologue and epilogue for funclets on Windows 

    The generated code for a funclet can have an add to sp in the epilogue
for which there is no corresponding sub in the prologue.

This patch removes the early return from emitPrologue that was
preventing the sub to sp, and instead conditionalizes the appropriate
parts of the rest of the function.

Fixes https://bugs.llvm.org/show_bug.cgi?id=45345

Differential Revision: https://reviews.llvm.org/D77015
    @danielframpton
    danielframpton committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    5e3cf56 View commit details
    Browse the repository at this point in the history

  2. [AArch64] Change AArch64 Windows EH UnwindHelp object to be a fixed o… 

    …bject

The UnwindHelp object is used during exception handling by runtime
code. It must be findable from a fixed offset from FP.

This change allocates the UnwindHelp object as a fixed object (as is
done for x86_64) to ensure that both the generated code and runtime
agree on the location of the object.

Fixes https://bugs.llvm.org/show_bug.cgi?id=45346

Differential Revision: https://reviews.llvm.org/D77016
    @danielframpton
    danielframpton committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    bb1d6bc View commit details
    Browse the repository at this point in the history